Skip to content

Commit 5d3f56f

Browse files
author
Alex Zherdev
committed
Use SHA1 instead of MD5 for caching
1 parent ab47e98 commit 5d3f56f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/active_model/serializer/concerns/caching.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def _cache_digest
5656
def digest_caller_file(caller_line)
5757
serializer_file_path = caller_line[CALLER_FILE]
5858
serializer_file_contents = IO.read(serializer_file_path)
59-
Digest::MD5.hexdigest(serializer_file_contents)
59+
Digest::SHA1.hexdigest(serializer_file_contents)
6060
rescue TypeError, Errno::ENOENT
6161
warn <<-EOF.strip_heredoc
6262
Cannot digest non-existent file: '#{caller_line}'.

test/cache_test.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -447,13 +447,13 @@ def test_a_serializer_rendered_by_two_adapter_returns_differently_fetch_attribut
447447

448448
def test_uses_file_digest_in_cache_key
449449
render_object_with_cache(@blog)
450-
file_digest = Digest::MD5.hexdigest(File.open(__FILE__).read)
450+
file_digest = Digest::SHA1.hexdigest(File.open(__FILE__).read)
451451
key = "#{@blog.cache_key}/#{adapter.cache_key}/#{file_digest}"
452452
assert_equal(@blog_serializer.attributes, cache_store.fetch(key))
453453
end
454454

455455
def test_cache_digest_definition
456-
file_digest = Digest::MD5.hexdigest(File.open(__FILE__).read)
456+
file_digest = Digest::SHA1.hexdigest(File.open(__FILE__).read)
457457
assert_equal(file_digest, @post_serializer.class._cache_digest)
458458
end
459459

@@ -560,7 +560,7 @@ def test_digest_caller_file
560560
path = file.path
561561
caller_line = "#{path}:1:in `<top (required)>'"
562562
file.close
563-
assert_equal ActiveModel::Serializer.digest_caller_file(caller_line), Digest::MD5.hexdigest(contents)
563+
assert_equal ActiveModel::Serializer.digest_caller_file(caller_line), Digest::SHA1.hexdigest(contents)
564564
ensure
565565
file.unlink
566566
FileUtils.remove_entry dir

0 commit comments

Comments
 (0)