Skip to content

Commit 24df294

Browse files
jrochkindrafaelfranca
andauthoredOct 21, 2019
Apply suggestions from code review
Co-Authored-By: Rafael França <rafael@franca.dev>
1 parent 9bcff52 commit 24df294

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
 

‎UPGRADING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ When compiling assets with Sprockets, Sprockets needs to decide which top-level
4545

4646
If you are using sprockets prior to 4.0, Rails will compile `application.css`, `application.js`; and *any* files found in your assets directory(ies) that are _not_ recognized as JS or CSS, but do have a filename extension. That latter was meant to apply to all your images usually in `./app/assets/images/`, but could have targetted other files as well.
4747

48-
If you wanted to specify additional assets to deliver that were not included by this logic, for instance for a marketing page iwht its own CSS, you might add something like this:
48+
If you wanted to specify additional assets to deliver that were not included by this logic, for instance for a marketing page with its own CSS, you might add something like this:
4949

5050

5151
```ruby
@@ -65,7 +65,7 @@ The default `manifest.js` created by `rails new` for the past few Rails versions
6565
//= link_directory ../stylesheets .css
6666
```
6767

68-
This says to include the contents of all file found in the `./app/assets/images` directory or any subdirectories. And any files recognized as CSS directly at `./app/assets/stylesheets` or as JS at `./app/assets/javascripts` (not including subdirectories). (The JS line is not generated in Rails 6.0.0 apps, since Rails 6.0 apps do not manage JS with sprockets).
68+
This says to include the contents of all file found in the `./app/assets/images` directory or any subdirectories. And any files recognized as CSS directly at `./app/assets/stylesheets` or as JS at `./app/assets/javascripts` (not including subdirectories). (The JS line is not generated in Rails 6.0 apps, since Rails 6.0 apps do not manage JS with sprockets).
6969

7070
Since the default logic for determining top-level targets changed, you might find some files that were currently compiled by sprockets for delivery to browser no longer are. You will have to edit the `manifest.js` to specify those files.
7171

0 commit comments

Comments
 (0)
Please sign in to comment.