Skip to content

fix: cap recent completed transactions at 10 - #2687

Open
grandpig wants to merge 1 commit into
rainbow-me:mainfrom
grandpig:main
Open

fix: cap recent completed transactions at 10#2687
grandpig wants to merge 1 commit into
rainbow-me:mainfrom
grandpig:main

Conversation

@grandpig

@grandpig grandpig commented Aug 3, 2026

Copy link
Copy Markdown

Summary

  • Fix an off-by-one error in the transaction store
  • Ensure that at most 10 completed transactions are retained
  • Keep pending transactions outside the completed transaction limit
  • Add a regression test

Root cause

The existing filter uses a post-increment with <=, which allows the 11th completed transaction to pass:

completedTransactionCount++ <= MAX_COMPLETED_TRANSACTIONS

Signed-off-by: grandpig <grandpig@outlook.com>
@grandpig
grandpig requested a review from a team as a code owner August 3, 2026 11:55
@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

@grandpig is attempting to deploy a commit to the rainbowdotme Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot

changeset-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

馃 Changeset detected

Latest commit: 9a2c7ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@rainbow-me/rainbowkit Patch
example Patch
@rainbow-me/rainbow-button Patch
rainbowkit-next-app Patch
site Patch
with-create-react-app Patch
with-next-app-i18n Patch
with-next-app Patch
with-next-custom-button Patch
with-next-mint-nft Patch
with-next-siwe-iron-session Patch
with-next-siwe-next-auth Patch
with-next-wallet-button Patch
with-next Patch
with-react-router Patch
with-remix Patch
with-vite Patch
with-next-rainbow-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@grandpig

grandpig commented Aug 4, 2026

Copy link
Copy Markdown
Author

@DanielSinclair Hi, Could you please review this PR at your convenience? Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant