Skip to content

Commit a725d68

Browse files
committed
mailbox: rp1: Don't claim channels in of_xlate
The of_xlate method saves the calculated event mask in the con_priv field. It also rejects subsequent attempt to use that channel because the mask is non-zero, which causes a repeated instantiation of a client driver to fail. The of_xlate method is not meant to be a point of resource acquisition. Leave the con_priv initialisation, but drop the test that it was previously zero. Signed-off-by: Phil Elwell <[email protected]>
1 parent dae233e commit a725d68

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/mailbox/rp1-mailbox.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,6 @@ static struct mbox_chan *rp1_mbox_xlate(struct mbox_controller *mbox,
133133
return ERR_PTR(-EINVAL);
134134

135135
chan = &mbox->chans[doorbell];
136-
if (chan->con_priv)
137-
return ERR_PTR(-EBUSY);
138136

139137
chan->con_priv = (void *)(uintptr_t)(1 << doorbell);
140138

0 commit comments

Comments
 (0)