Skip to content

Commit c763cf3

Browse files
6by9pelwell
authored andcommitted
drm: panel: ili9881: Correct symmetry on enable/disable return codes
ili9881c_enable is always returning 0. ili9881c_disable was returning the error code from mipi_dsi_dcs_set_display_off. If non-zero, the drm_panel framework will leave the panel marked as enabled, and not run the enable hook next time around. That isn't helpful, particularly as we're expecting unprepare to disable resets and regulators. Change ili9881c_disable to match enable in always returning 0. Signed-off-by: Dave Stevenson <[email protected]>
1 parent 536f209 commit c763cf3

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/gpu/drm/panel/panel-ilitek-ili9881c.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1745,7 +1745,9 @@ static int ili9881c_disable(struct drm_panel *panel)
17451745
{
17461746
struct ili9881c *ctx = panel_to_ili9881c(panel);
17471747

1748-
return mipi_dsi_dcs_set_display_off(ctx->dsi);
1748+
mipi_dsi_dcs_set_display_off(ctx->dsi);
1749+
1750+
return 0;
17491751
}
17501752

17511753
static int ili9881c_unprepare(struct drm_panel *panel)

0 commit comments

Comments
 (0)