RDBC-926 Refactor AI agent operations: replace manual null/empty checks with StringUtil.isNullOrEmpty, update schema validation condition for clarity.

Author: M4xymm

src/Documents/Operations/AI/Agents/AddOrUpdateAiAgentOperation.ts

@@ -11,7 +11,7 @@ import { RaftIdGenerator } from "../../../../Utility/RaftIdGenerator.js";
 import { throwError } from "../../../../Exceptions/index.js";
 import { HeadersBuilder } from "../../../../Utility/HttpUtil.js";
 
-function hasNoSampleObjectOrSchema(configuration: AiAgentConfiguration) {
+function hasNoSampleObjectAndSchema(configuration: AiAgentConfiguration) {
     return (!configuration.outputSchema || configuration.outputSchema.trim() === "")
         && (!configuration.sampleObject || configuration.sampleObject.trim() === "");
 }
@@ -20,17 +20,17 @@ export class AddOrUpdateAiAgentOperation implements IMaintenanceOperation<AiAgen
     private readonly _configuration: AiAgentConfiguration;
     private readonly _sampleObject?: unknown;
 
-    public constructor(configuration: AiAgentConfiguration, schemaType?: any) {
+    public constructor(configuration: AiAgentConfiguration, sampleObject?: any) {
         if (!configuration) {
             throwError("InvalidArgumentException", "configuration cannot be null or undefined.");
         }
 
-        if (!configuration.outputSchema && !configuration.sampleObject && !schemaType) {
+        if (!configuration.outputSchema && !configuration.sampleObject && !sampleObject) {
             throwError("InvalidArgumentException", "Please provide a non-empty value for either outputSchema or sampleObject.");
         }
         this._configuration = configuration;
-        if (schemaType) {
-            this._sampleObject = schemaType;
+        if (sampleObject) {
+            this._sampleObject = sampleObject;
         }
     }
 
@@ -51,7 +51,7 @@ class AddOrUpdateAiAgentCommand extends RavenCommand<AiAgentConfigurationResult>
 
     public constructor(configuration: AiAgentConfiguration, sampleSchema: any, conventions: DocumentConventions) {
         super();
-        if (hasNoSampleObjectOrSchema(configuration)) {
+        if (hasNoSampleObjectAndSchema(configuration)) {
             throwError("InvalidArgumentException", "Please provide a non-empty value for either outputSchema or sampleObject.");
         }
         this._configuration = configuration;

src/Documents/Operations/AI/Agents/RunConversationOperation.ts

@@ -12,6 +12,7 @@ import { HttpRequestParameters } from "../../../../Primitives/Http.js";
 import { throwError } from "../../../../Exceptions/index.js";
 import { JsonSerializer } from "../../../../Mapping/Json/Serializer.js";
 import { ObjectUtil } from "../../../../Utility/ObjectUtil.js";
+import { StringUtil } from "../../../../Utility/StringUtil.js";
 
 export class RunConversationOperation<TAnswer> implements IMaintenanceOperation<ConversationResult<TAnswer>> {
     private readonly _agentId: string;
@@ -29,10 +30,10 @@ export class RunConversationOperation<TAnswer> implements IMaintenanceOperation<
         options?: AiConversationCreationOptions,
         changeVector?: string
     ) {
-        if (!agentId) {
+        if (StringUtil.isNullOrEmpty(agentId)) {
             throwError("InvalidArgumentException", "agentId cannot be null or empty.");
         }
-        if (!conversationId) {
+        if (StringUtil.isNullOrEmpty(conversationId)) {
             throwError("InvalidArgumentException", "conversationId cannot be null or empty.");
         }
         this._agentId = agentId;

src/Documents/Operations/AI/AiConversation.ts

@@ -6,6 +6,7 @@ import type { ConversationResult } from "./Agents/ConversationResult.js";
 import type { AiAnswer } from "./AiAnswer.js";
 import type { IDocumentStore } from "../../IDocumentStore.js";
 import { throwError } from "../../../Exceptions/index.js";
+import { StringUtil } from "../../../Utility/StringUtil.js";
 
 export enum AiHandleErrorStrategy {
     SendErrorsToModel = "SendErrorsToModel",
@@ -27,9 +28,9 @@ export class AiConversation {
 
     public constructor(store: IDocumentStore, databaseName: string, agentId: string, conversationId: string, options?: AiConversationCreationOptions, changeVector?: string) {
         if (!store) throwError("InvalidArgumentException", "store is required");
-        if (!databaseName) throwError("InvalidArgumentException", "databaseName is required");
-        if (!agentId) throwError("InvalidArgumentException", "agentId is required");
-        if (!conversationId) throwError("InvalidArgumentException", "conversationId is required");
+        if (StringUtil.isNullOrEmpty(databaseName)) throwError("InvalidArgumentException", "databaseName is required");
+        if (StringUtil.isNullOrEmpty(agentId)) throwError("InvalidArgumentException", "agentId is required");
+        if (StringUtil.isNullOrEmpty(conversationId)) throwError("InvalidArgumentException", "conversationId is required");
 
         this._store = store;
         this._databaseName = databaseName;

src/Documents/Operations/AI/AiOperations.ts

@@ -37,9 +37,9 @@ export class AiOperations {
      */
     public async createAgent<TSchema>(
         configuration: AiAgentConfiguration,
-        schemaType?: TSchema
+        sampleObject?: TSchema
     ): Promise<AiAgentConfigurationResult> {
-        const operation = new AddOrUpdateAiAgentOperation(configuration, schemaType);
+        const operation = new AddOrUpdateAiAgentOperation(configuration, sampleObject);
         return await this._executor.send(operation);
     }