Skip to content

Commit fe5a892

Browse files
authored
Merge pull request #371 from ml054/RDBC-432
RDBC-432 get rid of bluebird from node.js client - partial work
2 parents a509296 + bb2ade8 commit fe5a892

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

src/Documents/Operations/OperationCompletionAwaiter.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
import * as BluebirdPromise from "bluebird";
21
import { GetOperationStateCommand } from "./GetOperationStateOperation";
32
import { RavenCommand, IRavenResponse } from "../../Http/RavenCommand";
43
import { throwError } from "../../Exceptions";
54
import { OperationExceptionResult } from "./OperationAbstractions";
65
import { ExceptionDispatcher } from "../../Exceptions";
76
import { DocumentConventions } from "../Conventions/DocumentConventions";
87
import { RequestExecutor } from "../../Http/RequestExecutor";
8+
import { delay } from "../../Utility/PromiseUtil";
99

1010
type OperationStatus = "Completed" | "Canceled" | "Faulted";
1111

@@ -47,7 +47,7 @@ export class OperationCompletionAwaiter {
4747

4848
public waitForCompletion(): Promise<void> {
4949
const operationStatusPolling = () => {
50-
return BluebirdPromise.resolve()
50+
return Promise.resolve()
5151
.then(() => this._fetchOperationStatus())
5252
.then((operationStatusResult) => {
5353
const operationStatus = operationStatusResult.status as OperationStatus;
@@ -65,7 +65,7 @@ export class OperationCompletionAwaiter {
6565
}
6666
}
6767

68-
return BluebirdPromise.delay(500)
68+
return delay(500)
6969
.then(() => operationStatusPolling());
7070
});
7171
};

test/Ported/BulkInsert/BulkInsertsTest.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import DocumentStore, {
66
} from "../../../src";
77
import { createMetadataDictionary } from "../../../src/Mapping/MetadataAsDictionary";
88
import { CONSTANTS } from "../../../src/Constants";
9-
import * as BluebirdPromise from "bluebird";
109
import { DateUtil } from "../../../src/Utility/DateUtil";
10+
import { delay } from "../../../src/Utility/PromiseUtil";
1111

1212
describe("bulk insert", function () {
1313

@@ -99,7 +99,7 @@ describe("bulk insert", function () {
9999
await bulkInsert.store(new FooBar());
100100
await bulkInsert.store(new FooBar());
101101
await bulkInsert.store(new FooBar());
102-
await BluebirdPromise.delay(500);
102+
await delay(500);
103103
await bulkInsert.abort();
104104
await bulkInsert.store(new FooBar());
105105

test/Ported/Indexing/IndexesFromClientTest.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import * as BluebirdPromise from "bluebird";
21
import * as assert from "assert";
32
import {
43
testContext,
@@ -29,6 +28,7 @@ import { DeleteIndexOperation } from "../../../src/Documents/Operations/Indexes/
2928
import { QueryStatistics } from "../../../src/Documents/Session/QueryStatistics";
3029
import { MoreLikeThisOptions } from "../../../src/Documents/Queries/MoreLikeThis/MoreLikeThisOptions";
3130
import { IndexCreation } from "../../../src/Documents/Indexes/IndexCreation";
31+
import { delay } from "../../../src/Utility/PromiseUtil";
3232

3333
describe("Indexes from client", function () {
3434

@@ -84,7 +84,7 @@ describe("Indexes from client", function () {
8484

8585
const indexName = new UsersIndex().getIndexName();
8686

87-
await BluebirdPromise.delay(2000);
87+
await delay(2000);
8888

8989
await store.maintenance.send(new ResetIndexOperation(indexName));
9090
await testContext.waitForIndexing(store);
@@ -283,7 +283,7 @@ describe("Indexes from client", function () {
283283
}
284284

285285
{
286-
// make queries to create auto indexes
286+
// make queries to create auto indexes
287287
const session = store.openSession();
288288
let stats: QueryStatistics;
289289
let users = await session.query(User)

test/TestDriver/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,7 @@ class ReplicationTestBase2 {
532532
const session = docStore.openSession();
533533
await session.load(id);
534534

535-
await BluebirdPromise.delay(10);
535+
await delay(10);
536536
} catch (e) {
537537
if (e.name === "DocumentConflictException") {
538538
return;

0 commit comments

Comments
 (0)