RDBC-954 Python client: fix Connection String R/W Bugs (OLAP + AI)

Author: yh-0

ravendb/documents/operations/ai/ai_connection_string.py

@@ -17,7 +17,7 @@ class AiModelType(enum.Enum):
     CHAT = "Chat"
 
 
-class AiConnectionString(ConnectionString):  # todo kuba
+class AiConnectionString(ConnectionString):
     def __init__(
         self,
         name: str,

ravendb/documents/operations/backups/settings.py

@@ -68,14 +68,20 @@ def __init__(
     def from_json(cls, json_dict: Dict[str, Any]) -> LocalSettings:
         return cls(
             json_dict["Disabled"],
-            GetBackupConfigurationScript.from_json(json_dict["GetBackupConfigurationScript"]),
+            (
+                GetBackupConfigurationScript.from_json(json_dict["GetBackupConfigurationScript"])
+                if json_dict["GetBackupConfigurationScript"]
+                else None
+            ),
             json_dict["FolderPath"],
         )
 
     def to_json(self) -> Dict[str, Any]:
         return {
             "Disabled": self.disabled,
-            "GetBackupConfigurationScript": self.get_backup_configuration_script.to_json(),
+            "GetBackupConfigurationScript": (
+                self.get_backup_configuration_script.to_json() if self.get_backup_configuration_script else None
+            ),
             "FolderPath": self.folder_path,
         }
 

ravendb/documents/operations/connection_string/remove_connection_string_operation.py

@@ -4,9 +4,10 @@
 
 import requests
 
-from ravendb import RavenCommand, RaftCommand, ConnectionString, ServerNode
+from ravendb import RavenCommand, RaftCommand, ServerNode
 from ravendb.documents.operations.definitions import MaintenanceOperation
 from ravendb.util.util import RaftIdGenerator
+from ravendb.serverwide.server_operation_executor import ConnectionStringType
 
 
 class RemoveConnectionStringResult:
@@ -17,27 +18,29 @@ def to_json(self) -> Dict:
         return {"RaftCommandIndex": self.raft_command_index}
 
     @classmethod
-    def from_json(cls, json_dict: Dict) -> "PutConnectionStringResult":
+    def from_json(cls, json_dict: Dict) -> "RemoveConnectionStringResult":
         return cls(json_dict["RaftCommandIndex"])
 
 
 class RemoveConnectionStringOperation(MaintenanceOperation[RemoveConnectionStringResult]):
-    def __init__(self, connection_string: ConnectionString = None):
-        self._connection_string = connection_string
+    def __init__(self, connection_string_name: str, connection_string_type: ConnectionStringType):
+        self._connection_string_name = connection_string_name
+        self._connection_string_type = connection_string_type
 
-    def get_command(self, conventions: "DocumentConventions") -> "RavenCommand[_T]":
-        return self.RemoveConnectionStringCommand(self._connection_string)
+    def get_command(self, conventions: "DocumentConventions") -> "RavenCommand[RemoveConnectionStringResult]":
+        return self.RemoveConnectionStringCommand(self._connection_string_name, self._connection_string_type)
 
     class RemoveConnectionStringCommand(RavenCommand[RemoveConnectionStringResult], RaftCommand):
-        def __init__(self, connection_string: ConnectionString = None):
+        def __init__(self, connection_string_name: str, connection_string_type: ConnectionStringType):
             super().__init__(RemoveConnectionStringResult)
-            self._connection_string = connection_string
+            self._connection_string_name = connection_string_name
+            self._connection_string_type = connection_string_type
 
         def is_read_request(self) -> bool:
             return False
 
         def create_request(self, node: ServerNode) -> requests.Request:
-            url = f"{node.url}/databases/{node.database}/admin/connection-strings?connectionString={urllib.parse.quote(self._connection_string.name)}&type={self._connection_string.get_type}"
+            url = f"{node.url}/databases/{node.database}/admin/connection-strings?connectionString={urllib.parse.quote(self._connection_string_name)}&type={self._connection_string_type.value}"
 
             request = requests.Request("DELETE")
             request.url = url