From 28acaa8948965b4d3c5d4e67b8f3e37c3a6b9e9c Mon Sep 17 00:00:00 2001 From: hirra Date: Mon, 22 Feb 2021 15:42:03 +0800 Subject: [PATCH] fix: correct the result of "{ a || b && 1}" --- packages/jsx-compiler/src/modules/__tests__/condition.js | 4 ++-- packages/jsx-compiler/src/modules/condition.js | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/jsx-compiler/src/modules/__tests__/condition.js b/packages/jsx-compiler/src/modules/__tests__/condition.js index 7b182b68..ba578eef 100644 --- a/packages/jsx-compiler/src/modules/__tests__/condition.js +++ b/packages/jsx-compiler/src/modules/__tests__/condition.js @@ -75,7 +75,7 @@ describe('Transform condition', () => { `); _transformTemplate(ast, {}, adapter, {}); expect(genCode(ast).code).toEqual(` - 1{a} + 1 `); }); @@ -87,7 +87,7 @@ describe('Transform condition', () => { `); _transformTemplate(ast, {}, adapter, {}); expect(genCode(ast).code).toEqual(` - 1{b}{a} + 1 `); }); diff --git a/packages/jsx-compiler/src/modules/condition.js b/packages/jsx-compiler/src/modules/condition.js index 807002c7..0c8b80bc 100644 --- a/packages/jsx-compiler/src/modules/condition.js +++ b/packages/jsx-compiler/src/modules/condition.js @@ -131,9 +131,6 @@ function transformTemplate(ast, templateMap, adapter, code) { replacement.push(createJSX('block', { [adapter.if]: generateConditionValue(test, { adapter }) }, children)); - replacement.push(createJSX('block', { - [adapter.else]: null, - }, [t.jsxExpressionContainer(left)])); } if (replacement.length > 0) { path.parentPath.replaceWithMultiple(replacement);