Improve log message wording when service already exists during reconciliation (#4096)

acrewdson · web-flow · commit eb66a26b78b7 · 2025-09-24T09:51:16.000-07:00
diff --git a/ray-operator/controllers/ray/rayservice_controller.go b/ray-operator/controllers/ray/rayservice_controller.go
@@ -880,7 +880,7 @@ func (r *RayServiceReconciler) reconcileServices(ctx context.Context, rayService
 	if err == nil {
 		// Only update the service if the RayCluster switches.
 		if newSvc.Spec.Selector[utils.RayClusterLabelKey] == oldSvc.Spec.Selector[utils.RayClusterLabelKey] {
-			logger.Info("Service has already exists in the RayCluster, skip Update", "rayCluster", newSvc.Spec.Selector[utils.RayClusterLabelKey], "serviceType", serviceType)
+			logger.Info("Service already exists in the RayCluster, skipping Update", "rayCluster", newSvc.Spec.Selector[utils.RayClusterLabelKey], "serviceType", serviceType)
 			return oldSvc, nil
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -880,7 +880,7 @@ func (r *RayServiceReconciler) reconcileServices(ctx context.Context, rayService`
`880`	`880`	`if err == nil {`
`881`	`881`	`// Only update the service if the RayCluster switches.`
`882`	`882`	`if newSvc.Spec.Selector[utils.RayClusterLabelKey] == oldSvc.Spec.Selector[utils.RayClusterLabelKey] {`
`883`		`- logger.Info("Service has already exists in the RayCluster, skip Update", "rayCluster", newSvc.Spec.Selector[utils.RayClusterLabelKey], "serviceType", serviceType)`
	`883`	`+ logger.Info("Service already exists in the RayCluster, skipping Update", "rayCluster", newSvc.Spec.Selector[utils.RayClusterLabelKey], "serviceType", serviceType)`
`884`	`884`	`return oldSvc, nil`
`885`	`885`	`}`
`886`	`886`