Skip to content

Conversation

eicherseiji
Copy link
Contributor

@eicherseiji eicherseiji commented Sep 16, 2025

Why are these changes needed?

  • Make aggregation interval configurable
  • Fix TPOT/TTFT units

Before
Screenshot 2025-09-16 at 4 46 06 PM

After
Screenshot 2025-09-16 at 4 51 06 PM

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(
    • Manual test

@eicherseiji eicherseiji added the go add ONLY when ready to merge, run all tests label Sep 16, 2025
@eicherseiji eicherseiji marked this pull request as ready for review September 16, 2025 23:52
@eicherseiji eicherseiji requested a review from a team as a code owner September 16, 2025 23:52
@ray-gardener ray-gardener bot added serve Ray Serve Related Issue llm labels Sep 17, 2025
Copy link
Contributor

@alanwguo alanwguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself looks good,

my feedback is more of a UX question which you guys are the owners of so approving to unblock.

@@ -89,6 +89,46 @@
"$__all"
]
}
},
{
"name": "interval",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will users actually know what this means and why they should customize it?

Alternatively, you can use the grafana built in variables $__rate_interval or $__interval which is set by grafana based on what timerange they select.

I think in the grafana UI, you can explicitly override the intervals as well and it will apply it to all the promql if you use the $__interval variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests llm serve Ray Serve Related Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants