Bindings error in expression.evaluate() method

[tokebe]

Thanks for writing this package! It shocks me that jsonata isn't more popular.

Bindings appear to be broken in the evaluate method, minimal example:

import jsonata
expr = jsonata.Jsonata("$ & $test_value")
expr.evaluate("a string!", {"test_value": "test"})

Produces error:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/jcallaghan/.pyenv/versions/3.11.10/lib/python3.11/site-packages/jsonata/jsonata.py", line 1947, in evaluate
    for k, v in bindings.bindings.items():
                ^^^^^^^^^^^^^^^^^
AttributeError: 'dict' object has no attribute 'bindings'

However, expression.assign() still seems to work:

import jsonata
expr = jsonata.Jsonata("$ & $test_value")
expr.assign("test_value", "test")
print(expr.evaluate("a string!"))

Outputs as expected:

a string!test

[rayokota]

The bindings parameter needs to an instance of Jsonata.Frame. The following works

        expr = jsonata.Jsonata("$ & $test_value")
        frame = jsonata.Jsonata.Frame(None)
        frame.bind("test_value", "test")
        expr.evaluate("a string!", frame) == "a string!test"

[tokebe]

This goes against the reference implementation documentation. Is this an intentional departure from being a strict port of the reference implementation?

I'd be happy to make a PR...

[rayokota]

Right, this port is more closely aligned with the Java implementation. See https://github.com/dashjoin/jsonata-java?tab=readme-ov-file#custom-functions