Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple owners in Grants #371

Open
rahmatrhd opened this issue Mar 1, 2023 · 0 comments
Open

Multiple owners in Grants #371

rahmatrhd opened this issue Mar 1, 2023 · 0 comments
Labels
enhancement New feature or request grant

Comments

@rahmatrhd
Copy link
Member

Summary

Grant can represent access for non-individual users like service accounts and groups for GCP providers. Ideally, those grants should be owned by a group of people for visibility and access maintainability so that when the main owner is no longer available, anyone else still can maintain the access.
This multiple ownership mostly will be used for channel of notifications purpose when the access is going to expire

Proposed solution

1. (Option 1) Add co_owners field in Grant

Pros:

  • Can have a concept of main owner and additional ones
  • This approach is simpler in implementation since it is a new column/field addition to the Grant entity

Cons:

  • When it comes to expiring access notifications, need to make sure that the notification is sent for both owner and co-owners. Same for other similar use cases (if any)

2. (Option 2) Replace owner: string (singular) field with owners: []string (multiple)

Pros:

  • Simpler domain knowledge as there is no confusion between the "main" owner and other owners.

Cons:

  • Need to migrate existing owner to the new owners field (breaking changes)

Additional

Assigning grant ownership to a "team" like [email protected] or any other kind of team/group can't be that straightforward since there is no team/group management in Guardian (and let's keep it so). To enable this, guardian needs to connect with third-party team management service like shield or google workspace for getting the information of team/group membership

@rahmatrhd rahmatrhd added enhancement New feature or request grant labels Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request grant
Projects
None yet
Development

No branches or pull requests

1 participant