Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to support windows? #71

Open
spindensity opened this issue Sep 27, 2021 · 4 comments
Open

Any plan to support windows? #71

spindensity opened this issue Sep 27, 2021 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@spindensity
Copy link

spindensity commented Sep 27, 2021

This plugin works very well on linux, but does not work on windows, since the pty module does not work on windows according to python's official documentation(in fact, it does not work on windows at all since there's no termios module):

import errno
import os
import pty
import select
from contextlib import contextmanager

The pty module defines operations for handling the pseudo-terminal concept: starting another process and being able to write to and read from its controlling terminal programmatically.

Because pseudo-terminal handling is highly platform dependent, there is code to do it only for Linux. (The Linux code is supposed to work on other platforms, but hasn’t been tested yet.)

Any plan to support windows?

@rcarriga
Copy link
Owner

Yep I've thought about this before but I do not develop on windows and do not have the time to get setup and be able to test. I'd certainly be interested in adding support for it though, I believe the only issue would be in the handle.py file, which can be altered though it would mean that the UltestAttach command would not be available as it requires the pty module. If there is an alternative solution I'd be open to hearing it, but for first steps I'd be happy with just getting the rest working.

I don't have much time right now to work on this but I'd be open to PRs, otherwise I'll get around to it when I have a chance 😄

@rcarriga rcarriga added enhancement New feature or request help wanted Extra attention is needed labels Sep 28, 2021
@DasOhmoff
Copy link

Yeah, please support Windows, that would be great! :)

@viktorhelgi
Copy link

Same here, would love to be able to use this plugin on Windows.

@rcarriga
Copy link
Owner

rcarriga commented Jun 8, 2022

If you are using NeoVim I'd recommend checking out my new plugin https://github.com/rcarriga/neotest which is a successor to vim-ultest. It should support windows (if not let me know in an issue please) as it's not using any Unix specific code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants