From 615b9ccc068121c78b21ffd531a0703ef97726f9 Mon Sep 17 00:00:00 2001 From: afc163 Date: Sun, 12 Jan 2025 15:22:14 +0800 Subject: [PATCH] fix: tagRender should not be called when value is empty --- src/Selector/MultipleSelector.tsx | 4 ++++ tests/Tags.test.tsx | 14 ++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/src/Selector/MultipleSelector.tsx b/src/Selector/MultipleSelector.tsx index 5c7fac70..1ec942a6 100644 --- a/src/Selector/MultipleSelector.tsx +++ b/src/Selector/MultipleSelector.tsx @@ -178,6 +178,10 @@ const SelectSelector: React.FC = (props) => { }; const renderRest = (omittedValues: DisplayValueType[]) => { + // https://github.com/ant-design/ant-design/issues/48930 + if (!values.length) { + return null; + } const content = typeof maxTagPlaceholder === 'function' ? maxTagPlaceholder(omittedValues) diff --git a/tests/Tags.test.tsx b/tests/Tags.test.tsx index 830db1e3..e9e80904 100644 --- a/tests/Tags.test.tsx +++ b/tests/Tags.test.tsx @@ -301,6 +301,20 @@ describe('Select.Tags', () => { expectOpen(container, false); }); + // https://github.com/ant-design/ant-design/issues/48930 + it('should not call tagRender when value is empty', () => { + const tagRender = jest.fn(); + render( +