The select component is in uncontrolled mode. After selecting the value, modify the options, and the label of the value does not follow the modification #45734

Activity

1. github-actions

   added

   unconfirmed

   on Nov 8, 2023
2. ouzhou commented on Nov 8, 2023

   

   ouzhou

   on Nov 8, 2023

   Last edited by ouzhou

   Author

   More actions

   find a solution, just remove undefined determine below

           if (rawLabel === undefined)
                 rawLabel = option?.[optionLabelProp || mergedFieldNames.label];
               if (rawKey === undefined) rawKey = option?.key ?? rawValue;
   

   to

        rawLabel = option?.[optionLabelProp || mergedFieldNames.label];
        rawKey = option?.key ?? rawValue;
   
   

   https://github.com/react-component/select/blob/ec0c6c748a24aa500ede15f1d2aacd0dacf4f63b/src/Select.tsx#L275
   https://github.com/react-component/select/blob/ec0c6c748a24aa500ede15f1d2aacd0dacf4f63b/src/Select.tsx#L277
3. ouzhou commented on Nov 8, 2023

   

   ouzhou

   on Nov 8, 2023

   Author

   More actions

   because when component re-render, rawLabel and rawKey not be re-assign value
4. chenmijiang commented on Nov 9, 2023

   

   chenmijiang

   on Nov 9, 2023

   More actions

   for controlled components, your usage of the "onChange" method is wrong. It is not a native method. Just pass the value directly, like this:
   
5. ouzhou commented on Nov 9, 2023

   

   ouzhou

   on Nov 9, 2023

   Author

   More actions

   i fixed the demo
6. MadCcc

   added

   🐛 BugAnt Design Team had proved that this is a bug.Ant Design Team had proved that this is a bug.

   and removed

   unconfirmed

   on Nov 10, 2023
7. github-actions

   added

   Inactive

   on Dec 16, 2023
8. bbb169 commented on Dec 22, 2023

   

   bbb169

   on Dec 22, 2023

   Contributor

   More actions

   
   https://github.com/react-component/select/blob/ec0c6c748a24aa500ede15f1d2aacd0dacf4f63b/src/Select.tsx#L289
   本质还是internalValue这个值在select选择的时候会被triggerChange改变，当新的选项刷新试就会走到这个逻辑，要不要在这块增加一个逻辑，如果新旧label不匹配，就更新internalValue为新的值呢
9. afc163 commented on Dec 22, 2023

   

   afc163

   on Dec 22, 2023

   Member

   More actions

   @bbb169 思路是可以的，但是最好不要在 convert2LabelValues 里做。convert2LabelValues 最好是个纯函数，不应该加副作用。