Skip to content

Commit 2b86fce

Browse files
authored
feat: remove *-show-arrow cls when showArrow is true (#433)
* feat: remove *-show-arrow cls when showArrow is true * feat: update test case
1 parent bf78c2e commit 2b86fce

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

src/Tooltip.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import type { TriggerProps } from 'rc-trigger';
55
import type { AlignType, AnimationType, ActionType } from 'rc-trigger/lib/interface';
66
import { placements } from './placements';
77
import Popup from './Popup';
8-
import classNames from 'classnames';
98

109
export interface TooltipProps extends Pick<TriggerProps, 'onPopupAlign' | 'builtinPlacements'> {
1110
trigger?: ActionType | ActionType[];
@@ -102,9 +101,7 @@ const Tooltip = (props: TooltipProps, ref) => {
102101

103102
return (
104103
<Trigger
105-
popupClassName={classNames(overlayClassName, {
106-
[`${prefixCls}-show-arrow`]: showArrow,
107-
})}
104+
popupClassName={overlayClassName}
108105
prefixCls={prefixCls}
109106
popup={getPopupElement}
110107
action={trigger}

tests/index.test.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,6 @@ describe('rc-tooltip', () => {
174174
</Tooltip>,
175175
);
176176
fireEvent.click(container.querySelector('.target'));
177-
expect(container.querySelector('.rc-tooltip').classList).toContain('rc-tooltip-show-arrow');
178177
expect(container.querySelector('.rc-tooltip-content').outerHTML).toBe(
179178
'<div class="rc-tooltip-content"><div class="rc-tooltip-arrow"></div><div class="rc-tooltip-inner" role="tooltip"><strong class="x-content">Tooltip content</strong></div></div>',
180179
);
@@ -192,7 +191,6 @@ describe('rc-tooltip', () => {
192191
</Tooltip>,
193192
);
194193
fireEvent.click(container.querySelector('.target'));
195-
expect(container.querySelector('.rc-tooltip').classList).toContain('rc-tooltip-show-arrow');
196194
expect(container.querySelector('.rc-tooltip-content').outerHTML).toBe(
197195
'<div class="rc-tooltip-content"><div class="rc-tooltip-arrow"></div><div class="rc-tooltip-inner" role="tooltip"><strong class="x-content">Tooltip content</strong></div></div>',
198196
);

0 commit comments

Comments
 (0)