Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on lodash #1

Open
souporserious opened this issue Oct 23, 2016 · 1 comment
Open

Don't depend on lodash #1

souporserious opened this issue Oct 23, 2016 · 1 comment

Comments

@souporserious
Copy link

How do you feel about going back to this for toPairs? It seems like lodash is a big dependency that can be avoided by using what you had before. Even moving to the lodash.topairs package is bigger than what you had prior. Is there any reason not to go back to the way it was before?

@d6u
Copy link
Member

d6u commented Oct 24, 2016

There is no reason to not go back 😄 except for my laziness and focus on the new component style API (detail see react-container-query/react-container-query#39). I think map can also be replaced with array.map (see https://github.com/d6u/container-query-toolkit/blob/1243cf226e6b173059119e80be750e910fff8f6e/src/matchQueries.ts#L17).

If you want to create a PR, I will gladly accept it. To be honest, there are also other issues with this repo, e.g. no cross browser testing on CI. If we want to create an organization to make contribution easier, we can think about a name here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants