You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Within the context of 'react-container-query', when passing initialSize={{ width: undefined }} or initialSize={{ width: null }} you get a true in matchQueries for that className to be applied.
I would think we'd want false to be set here wherever we have a none numerical value passed in. Granted you could do a check like initialSize={width && { width }} to get around this but this seems a bit verbose.
The text was updated successfully, but these errors were encountered:
navgarcha
changed the title
undefined width/value results in match
undefined or null width/height results in match
Mar 9, 2017
Above code return {a: true, b: true} in current behavior. Are you suggesting if we are missing width, all rules with {min|max}Width defined should be set to false, so above code should return {a: false, b: true}?
Within the context of 'react-container-query', when passing
initialSize={{ width: undefined }}
orinitialSize={{ width: null }}
you get atrue
inmatchQueries
for that className to be applied.I would think we'd want
false
to be set here wherever we have a none numerical value passed in. Granted you could do a check likeinitialSize={width && { width }}
to get around this but this seems a bit verbose.The text was updated successfully, but these errors were encountered: