Should return Errors, not throw them, from PropTypes

STRML · STRML · commit 5bf8dfe11ca2 · 2016-04-11T18:37:57.000-05:00
diff --git a/lib/utils/shims.es6 b/lib/utils/shims.es6
@@ -20,6 +20,6 @@ export function int(a: string): number {
 
 export function dontSetMe(props: Object, propName: string, componentName: string) {
   if (props[propName]) {
-    throw new Error(`Invalid prop ${propName} passed to ${componentName} - do not set this, set it on the child.`);
+    return new Error(`Invalid prop ${propName} passed to ${componentName} - do not set this, set it on the child.`);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,6 @@ export function int(a: string): number {`
`20`	`20`
`21`	`21`	`export function dontSetMe(props: Object, propName: string, componentName: string) {`
`22`	`22`	`if (props[propName]) {`
`23`		- throw new Error(`Invalid prop ${propName} passed to ${componentName} - do not set this, set it on the child.`);
	`23`	+ return new Error(`Invalid prop ${propName} passed to ${componentName} - do not set this, set it on the child.`);
`24`	`24`	`}`
`25`	`25`	`}`