feat(useMeasure): support custom measurers in order to support border-box and others#1603
Open
m-kolomoyets wants to merge 5 commits intoreact-hookz:masterfrom
Open
feat(useMeasure): support custom measurers in order to support border-box and others#1603m-kolomoyets wants to merge 5 commits intoreact-hookz:masterfrom
m-kolomoyets wants to merge 5 commits intoreact-hookz:masterfrom
Conversation
xobotyi
requested changes
Jan 30, 2025
Contributor
|
Thanks for contribution! |
xobotyi
changed the title
ResizeObserverEntry matcher callback
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1603 +/- ##
==========================================
+ Coverage 97.60% 97.80% +0.19%
==========================================
Files 63 63
Lines 1714 1868 +154
Branches 481 483 +2
==========================================
+ Hits 1673 1827 +154
Misses 39 39
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior, and the steps to reproduce the issue?
Current implementation of the
useMeasurehook calculates the element bounds based on content-box model only.It is a little unexpected behavior when the project and all the layout is based on border-box model and trying to calculate measures of the element has paddings.
Thus, current hook ignores paddings calculating element's width and height.
What is the expected behavior?
Giving the possibility to define custom measure matcher model to take the values needed.
How does this PR fix the problem?
By adding the additional optional function argument receives the
ResizeObserverEntryvalue and returns the new measures should be applied ornull. If function returnsnull, the default behavior is applied and content-box measures will be returned.Checklist
useMeasurehook elements box-sizing option #1548