From 265350638204f6c7838e22f69a9736000a9cc268 Mon Sep 17 00:00:00 2001 From: Hossein Mohammadi Date: Wed, 5 Aug 2020 10:35:57 +0430 Subject: [PATCH 1/3] fix: resolve deps of useBackHandler --- src/useBackHandler.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/useBackHandler.ts b/src/useBackHandler.ts index e8c31f3f..67238803 100644 --- a/src/useBackHandler.ts +++ b/src/useBackHandler.ts @@ -1,10 +1,10 @@ -import { useEffect } from "react" +import { DependencyList, useEffect } from "react" import { BackHandler } from "react-native" -export function useBackHandler(handler: () => boolean) { +export function useBackHandler(handler: () => boolean, deps: DependencyList = []) { useEffect(() => { - const subscription = BackHandler.addEventListener("hardwareBackPress", handler) + const sub = BackHandler.addEventListener("hardwareBackPress", handler) - return () => subscription.remove() - }, [handler]) + return () => sub.remove() + }, [handler, ...deps]) } From 4fd9ec31c18374565f66a2c890a6357f8294c299 Mon Sep 17 00:00:00 2001 From: Hossein Mohammadi Date: Wed, 5 Aug 2020 10:40:03 +0430 Subject: [PATCH 2/3] docs: readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 7aefcc18..53edfcf4 100644 --- a/README.md +++ b/README.md @@ -69,7 +69,7 @@ useBackHandler(() => { } // let the default thing happen return false -}) +},[shouldBeHandledHere]) ``` ### `useImageDimensions` From 1f02cf574644cc4a4321c5e27942d64d25b034f6 Mon Sep 17 00:00:00 2001 From: Pavlos Vinieratos Date: Fri, 21 Feb 2025 19:38:17 +0200 Subject: [PATCH 3/3] changeset --- .changeset/old-pianos-find.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/old-pianos-find.md diff --git a/.changeset/old-pianos-find.md b/.changeset/old-pianos-find.md new file mode 100644 index 00000000..95db1773 --- /dev/null +++ b/.changeset/old-pianos-find.md @@ -0,0 +1,5 @@ +--- +"@react-native-community/hooks": minor +--- + +dep list on useBackHandler