Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build, export real ESM #100

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Update build, export real ESM #100

merged 7 commits into from
Jan 6, 2025

Conversation

jquense
Copy link
Member

@jquense jquense commented Jan 3, 2025

This updates the build, test suite, etc to check for react 19 support and changes the output so that it produces true, native esm that can be used in node without compilation. Continues to provide the cjs build as well.

@jquense jquense requested a review from kyletsang January 3, 2025 16:27
Copy link
Collaborator

@kyletsang kyletsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random comments, but this looks good to me. I tested it in a random small project with storybook and didn't find any issues. When I get more time later, I'll try it in something bigger

@jquense jquense requested a review from kyletsang January 6, 2025 15:17
Copy link
Collaborator

@kyletsang kyletsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jquense jquense merged commit 20df684 into master Jan 6, 2025
3 checks passed
@jquense jquense deleted the esm branch January 6, 2025 18:28
jquense added a commit that referenced this pull request Jan 7, 2025
BREAKING CHANGE: exports native esm modules and removes the index file in favor of sub imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useRefWithInitialValueFactory not exported by index useMergedRef not being exported by index
2 participants