[RN] Make yarn the source of truth for native + Python formatting

Extend yarn-owned formatting to every synced non-JS language so GitHub CI is the
single source of truth and internal (Meta) + GitHub produce byte-identical
output, using the OSS toolchain:

- `scripts/lint/clang-format.sh` — clang-format `21.1.2` (C/C++/Obj-C).
- `scripts/lint/ktfmt.sh` — ktfmt `0.64` (Kotlin `.kt` and `.kts`).
- `scripts/lint/google-java-format.sh` — google-java-format `1.23.0` (Java).
- `scripts/lint/pyfmt.sh` — ufmt (`ruff-api` formatter + `usort`), configured in
  `pyproject.toml` (Python).
- `yarn f` runs Prettier + all four; each has a `-check` variant. The CI `lint`
  job runs all of them (JDK 17 via setup-java for ktfmt/google-java-format;
  Python provisions ufmt from PyPI).
- Reformats: 78 Kotlin `.kt` + 2 `.kts` to ktfmt `0.64`. C/C++/Obj-C, Java, and
  Python are already clean under the matching OSS releases, so no reformat there.

[Internal]

`yarn clang-format-check`, `yarn lint-kotlin-check`, `yarn lint-java-check`
(JDK 17), and `yarn lint-python-check` all clean on the synced tree; `yarn f`
formats JS + native + Python. The GitHub `lint` job runs all checks on this PR.

Changelog: [Internal]

Author: mattcarrollcode

.github/workflows/test-all.yml

@@ -514,6 +514,29 @@ jobs:
       - name: TypeScript (legacy deep imports / manual types)
         shell: bash
         run: yarn test-typescript-legacy
+      - name: Lint runner self-test (file enumeration)
+        shell: bash
+        run: ./scripts/lint/selftest.sh
+      - name: clang-format (C/C++/Obj-C)
+        shell: bash
+        run: yarn run clang-format-check
+      - name: Set up JDK 17
+        uses: actions/setup-java@v5
+        with:
+          java-version: '17'
+          distribution: 'zulu'
+      - name: ktfmt (Kotlin)
+        shell: bash
+        run: yarn run lint-kotlin-check
+      - name: Verify generated Kotlin is in sync with its generator
+        shell: bash
+        run: node packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/generate-nested-scroll-view.js --verify
+      - name: google-java-format (Java)
+        shell: bash
+        run: yarn run lint-java-check
+      - name: ufmt (Python)
+        shell: bash
+        run: yarn run lint-python-check
 
   test_js:
     runs-on: ubuntu-latest

build.gradle.kts

@@ -192,16 +192,17 @@ listOf("ktfmtCheck", "ktfmtFormat").forEach { taskName ->
 
 allprojects {
   // Apply exclusions for specific files that should not be formatted
-  val excludePatterns = listOf(
-      "**/build/**",
-      "**/hermes-engine/**",
-      "**/internal/featureflags/**",
-      "**/systeminfo/ReactNativeVersion.kt",
-  )
+  val excludePatterns =
+      listOf(
+          "**/build/**",
+          "**/hermes-engine/**",
+          "**/internal/featureflags/**",
+          "**/systeminfo/ReactNativeVersion.kt",
+      )
   listOf(
-      com.ncorti.ktfmt.gradle.tasks.KtfmtCheckTask::class,
-      com.ncorti.ktfmt.gradle.tasks.KtfmtFormatTask::class,
-  )
+          com.ncorti.ktfmt.gradle.tasks.KtfmtCheckTask::class,
+          com.ncorti.ktfmt.gradle.tasks.KtfmtFormatTask::class,
+      )
       .forEach { tasks.withType(it) { exclude(excludePatterns) } }
 
   // Disable the problematic ktfmt script tasks due to symbolic link issues in subprojects

package.json

@@ -9,19 +9,24 @@
     "build-android": "./gradlew :packages:react-native:ReactAndroid:build",
     "build": "node ./scripts/build/build.js",
     "build-types": "node ./scripts/js-api/build-types",
-    "clang-format": "clang-format -i --glob=*/**/*.{h,cpp,m,mm}",
+    "clang-format": "./scripts/lint/clang-format.sh",
+    "clang-format-check": "./scripts/lint/clang-format.sh --check",
     "clean": "node ./scripts/build/clean.js",
     "cxx-api-build": "python -m scripts.cxx-api.parser",
     "cxx-api-validate": "python -m scripts.cxx-api.parser --validate",
     "flow-check": "flow full-check",
     "flow": "flow",
-    "f": "yarn prettier",
+    "f": "yarn prettier && yarn clang-format && yarn lint-kotlin && yarn lint-java && yarn lint-python",
     "format-check": "prettier --list-different \"./**/*.{cjs,cts,flow,js,jsx,md,mjs,mts,ts,tsx,yaml,yml}\"",
-    "format": "yarn prettier && yarn clang-format",
+    "format": "yarn prettier && yarn clang-format && yarn lint-kotlin && yarn lint-java && yarn lint-python",
     "featureflags": "yarn --cwd packages/react-native featureflags",
     "js-api-diff": "node ./scripts/js-api/diff-api-snapshot",
-    "lint-kotlin-check": "./gradlew ktfmtCheck",
-    "lint-kotlin": "./gradlew ktfmtFormat",
+    "lint-java-check": "./scripts/lint/google-java-format.sh --check",
+    "lint-java": "./scripts/lint/google-java-format.sh",
+    "lint-kotlin-check": "./scripts/lint/ktfmt.sh --check",
+    "lint-kotlin": "./scripts/lint/ktfmt.sh",
+    "lint-python-check": "./scripts/lint/pyfmt.sh --check",
+    "lint-python": "./scripts/lint/pyfmt.sh",
     "lint-markdown": "markdownlint-cli2 2>&1",
     "lint": "eslint --max-warnings 0 .",
     "preinstall": "node ./scripts/try-set-hermes-compiler-prebuilt.js",

packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/ReactPlugin.kt

@@ -200,42 +200,44 @@ class ReactPlugin : Plugin<Project> {
     }
 
     // We create the tasks to produce schema from JS files and generate artifacts from schema.
-    val generateCodegenArtifactsTask = registerCodegenTasks(
-        project = project,
-        rootExtension = rootExtension,
-        generatedSrcDir = generatedSrcDir,
-        packageJsonFile = { findPackageJsonFile(project, rootExtension.root) },
-        schemaTaskName = "generateCodegenSchemaFromJavaScript",
-        artifactsTaskName = "generateCodegenArtifactsFromSchema",
-        configureJsRoot = { task, packageJson ->
-          // We're reading the package.json at configuration time to properly feed
-          // the `jsRootDir` @Input property of this task & the onlyIf. Therefore, the
-          // parsePackageJson should be invoked inside this lambda.
-          val parsedPackageJson = packageJson?.let { JsonUtils.fromPackageJson(it) }
-          val jsSrcsDirInPackageJson = parsedPackageJson?.codegenConfig?.jsSrcsDir
-
-          if (packageJson != null && jsSrcsDirInPackageJson != null) {
-            task.jsRootDir.set(File(packageJson.parentFile, jsSrcsDirInPackageJson))
-          } else {
-            task.jsRootDir.set(localExtension.jsRootDir)
-          }
-        },
-        configureCodegenArtifacts = { task, _ ->
-          task.codegenJavaPackageName.set(localExtension.codegenJavaPackageName)
-          task.libraryName.set(localExtension.libraryName)
-        },
-        onlyIf = { packageJson ->
-          // Please note that needsCodegenFromPackageJson is triggering a read of the
-          // package.json at configuration time as we need to feed the onlyIf condition of this
-          // task. Therefore, needsCodegenFromPackageJson needs to be invoked inside this
-          // lambda.
-          val needsCodegenFromPackageJson = project.needsCodegenFromPackageJson(rootExtension.root)
-          val parsedPackageJson = packageJson?.let { JsonUtils.fromPackageJson(it) }
-          val includesGeneratedCode =
-              parsedPackageJson?.codegenConfig?.includesGeneratedCode ?: false
-          (isLibrary || needsCodegenFromPackageJson) && !includesGeneratedCode
-        },
-    )
+    val generateCodegenArtifactsTask =
+        registerCodegenTasks(
+            project = project,
+            rootExtension = rootExtension,
+            generatedSrcDir = generatedSrcDir,
+            packageJsonFile = { findPackageJsonFile(project, rootExtension.root) },
+            schemaTaskName = "generateCodegenSchemaFromJavaScript",
+            artifactsTaskName = "generateCodegenArtifactsFromSchema",
+            configureJsRoot = { task, packageJson ->
+              // We're reading the package.json at configuration time to properly feed
+              // the `jsRootDir` @Input property of this task & the onlyIf. Therefore, the
+              // parsePackageJson should be invoked inside this lambda.
+              val parsedPackageJson = packageJson?.let { JsonUtils.fromPackageJson(it) }
+              val jsSrcsDirInPackageJson = parsedPackageJson?.codegenConfig?.jsSrcsDir
+
+              if (packageJson != null && jsSrcsDirInPackageJson != null) {
+                task.jsRootDir.set(File(packageJson.parentFile, jsSrcsDirInPackageJson))
+              } else {
+                task.jsRootDir.set(localExtension.jsRootDir)
+              }
+            },
+            configureCodegenArtifacts = { task, _ ->
+              task.codegenJavaPackageName.set(localExtension.codegenJavaPackageName)
+              task.libraryName.set(localExtension.libraryName)
+            },
+            onlyIf = { packageJson ->
+              // Please note that needsCodegenFromPackageJson is triggering a read of the
+              // package.json at configuration time as we need to feed the onlyIf condition of this
+              // task. Therefore, needsCodegenFromPackageJson needs to be invoked inside this
+              // lambda.
+              val needsCodegenFromPackageJson =
+                  project.needsCodegenFromPackageJson(rootExtension.root)
+              val parsedPackageJson = packageJson?.let { JsonUtils.fromPackageJson(it) }
+              val includesGeneratedCode =
+                  parsedPackageJson?.codegenConfig?.includesGeneratedCode ?: false
+              (isLibrary || needsCodegenFromPackageJson) && !includesGeneratedCode
+            },
+        )
 
     // We update the android configuration to include the generated sources.
     // This is equivalent to this DSL:
@@ -353,13 +355,14 @@ class ReactPlugin : Plugin<Project> {
         project.rootProject.layout.buildDirectory.file("generated/autolinking/autolinking.json")
     val pureCxxDependencies =
         getPureCxxCodegenDependencies(rootGeneratedAutolinkingFile.get().asFile)
-    val pureCxxCodegenTasks = configurePureCxxDependenciesCodegen(
-        project,
-        extension,
-        rootExtension,
-        generatedPureCxxSourceDir,
-        pureCxxDependencies,
-    )
+    val pureCxxCodegenTasks =
+        configurePureCxxDependenciesCodegen(
+            project,
+            extension,
+            rootExtension,
+            generatedPureCxxSourceDir,
+            pureCxxDependencies,
+        )
 
     // We add a task called generateAutolinkingPackageList to do not clash with the existing task
     // called generatePackageList. This can to be renamed once we unlink the rn <-> cli

packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/tasks/BundleHermesCTask.kt

@@ -109,12 +109,13 @@ abstract class BundleHermesCTask : DefaultTask() {
 
         val reactNativeDir = reactNativeDir.get().asFile
         val composeScriptFile = File(reactNativeDir, "scripts/compose-source-maps.js")
-        val composeSourceMapsCommand = getComposeSourceMapsCommand(
-            composeScriptFile,
-            packagerSourceMap,
-            compilerSourceMap,
-            outputSourceMap,
-        )
+        val composeSourceMapsCommand =
+            getComposeSourceMapsCommand(
+                composeScriptFile,
+                packagerSourceMap,
+                compilerSourceMap,
+                outputSourceMap,
+            )
         runCommand(composeSourceMapsCommand)
       }
     }

packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/PathUtils.kt

@@ -28,11 +28,12 @@ import org.gradle.api.file.DirectoryProperty
 internal fun detectedEntryFile(
     config: ReactExtension,
     envVariableOverride: String? = null,
-): File = detectEntryFile(
-    entryFile = config.entryFile.orNull?.asFile,
-    reactRoot = config.root.get().asFile,
-    envVariableOverride = envVariableOverride,
-)
+): File =
+    detectEntryFile(
+        entryFile = config.entryFile.orNull?.asFile,
+        reactRoot = config.root.get().asFile,
+        envVariableOverride = envVariableOverride,
+    )
 
 /**
  * Computes the CLI file for React Native. The Algo follows this order:
@@ -41,11 +42,12 @@ internal fun detectedEntryFile(
  * 3. The `node_modules/react-native/cli.js` file if exists
  * 4. Fails otherwise
  */
-internal fun detectedCliFile(config: ReactExtension): File = detectCliFile(
-    project = config.project,
-    reactNativeRoot = config.root.get().asFile,
-    preconfiguredCliFile = config.cliFile.asFile.orNull,
-)
+internal fun detectedCliFile(config: ReactExtension): File =
+    detectCliFile(
+        project = config.project,
+        reactNativeRoot = config.root.get().asFile,
+        preconfiguredCliFile = config.cliFile.asFile.orNull,
+    )
 
 /**
  * Computes the `hermesc` command location. The Algo follows this order: