Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dot notation in reactpy.web.export #543

Open
Archmonger opened this issue Dec 11, 2021 · 1 comment · Fixed by #1285
Open

Support dot notation in reactpy.web.export #543

Archmonger opened this issue Dec 11, 2021 · 1 comment · Fixed by #1285
Labels
flag-good-first-issue A well defined and self-contained task. priority-3-low May be resolved one any timeline.

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Dec 11, 2021 •
edited
Loading

Current Situation

Currently nested imports cannot be resolved, such as Bootstrap Navbar.Toggle

bootstrap = reactpy.web.module_from_template(
    "react", "react-bootstrap", resolve_exports=True
)
toggler = reactpy.web.export(bootstrap, "Navbar.Toggle")

Proposed Changes

Update reactpy.web.export to support dot notation by modifying this check to drill down into the module using the dot-separate names rather than just checking to see if it's a direct export. Here's how this could be done.

For more information see this comment.
@Archmonger Archmonger added the flag-triage Not prioritized. label Dec 11, 2021
@rmorshea rmorshea added enhancement and removed flag-triage Not prioritized. labels Jan 9, 2022
@rmorshea rmorshea added this to the 1.0 milestone Jan 11, 2022
@rmorshea rmorshea added the priority-2-moderate Should be resolved on a reasonable timeline. label Jan 13, 2022
@rmorshea rmorshea added the flag-good-first-issue A well defined and self-contained task. label Feb 9, 2022
@rmorshea
Copy link
Collaborator

Gonna push this to 2.0 since it's more of a nicety.

@rmorshea rmorshea added priority-3-low May be resolved one any timeline. and removed priority-2-moderate Should be resolved on a reasonable timeline. labels Nov 29, 2022
@rmorshea rmorshea modified the milestones: 1.0, 2.0 Nov 29, 2022
@Archmonger Archmonger modified the milestones: Luxury, Essential Jan 29, 2023
@rmorshea rmorshea removed this from the Essential milestone Feb 21, 2023
@Archmonger Archmonger changed the title Support dot notation in idom.web.export Support dot notation in reactpy.web.export Jan 26, 2025
@Archmonger Archmonger mentioned this issue Mar 18, 2025
Merged
4 tasks
@Archmonger Archmonger linked a pull request Mar 18, 2025 that will close this issue
Subcomponent notation #1285
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flag-good-first-issue A well defined and self-contained task. priority-3-low May be resolved one any timeline.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Subcomponent notation shawncrawley/reactpy
2 participants
@rmorshea @Archmonger