Skip to content

Commit 9c316b2

Browse files
Upgrade tailwind version (#6550)
* Fix overflowing text content in footer link Add an ellipsis to overflowing text in the footer section for navigating between different references. * Add min and max width to nextlink class * Add minwidth to tailwind config * Wrap string beyond max width * Remove title attribute from span element * Upgrade tailwind to 3.4.1 * Remove manual width config from minWidth * Remove minWidth from tailwind config and preserve default value of min-w-xs
1 parent 7a15e96 commit 9c316b2

File tree

7 files changed

+49
-54
lines changed

7 files changed

+49
-54
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
"retext": "^7.0.1",
9292
"retext-smartypants": "^4.0.0",
9393
"rss": "^1.2.2",
94-
"tailwindcss": "^3.3.2",
94+
"tailwindcss": "^3.4.1",
9595
"typescript": "^4.0.2",
9696
"unist-util-visit": "^2.0.3",
9797
"webpack-bundle-analyzer": "^4.5.0"

src/components/Layout/Feedback.tsx

+4-4
Original file line numberDiff line numberDiff line change
@@ -63,16 +63,16 @@ function SendFeedback({onSubmit}: {onSubmit: () => void}) {
6363
return (
6464
<div
6565
className={cn(
66-
'max-w-xs w-80 lg:w-auto py-3 shadow-lg rounded-lg m-4 bg-wash dark:bg-gray-95 px-4 flex',
66+
'max-w-custom-xs w-80 lg:w-auto py-3 shadow-lg rounded-lg m-4 bg-wash dark:bg-gray-95 px-4 flex',
6767
{exit: isSubmitted}
6868
)}>
69-
<p className="w-full font-bold text-primary dark:text-primary-dark text-lg me-4">
69+
<p className="w-full text-lg font-bold text-primary dark:text-primary-dark me-4">
7070
{isSubmitted ? 'Thank you for your feedback!' : 'Is this page useful?'}
7171
</p>
7272
{!isSubmitted && (
7373
<button
7474
aria-label="Yes"
75-
className="bg-secondary-button dark:bg-secondary-button-dark rounded-lg text-primary dark:text-primary-dark px-3 me-2"
75+
className="px-3 rounded-lg bg-secondary-button dark:bg-secondary-button-dark text-primary dark:text-primary-dark me-2"
7676
onClick={() => {
7777
setIsSubmitted(true);
7878
onSubmit();
@@ -84,7 +84,7 @@ function SendFeedback({onSubmit}: {onSubmit: () => void}) {
8484
{!isSubmitted && (
8585
<button
8686
aria-label="No"
87-
className="bg-secondary-button dark:bg-secondary-button-dark rounded-lg text-primary dark:text-primary-dark px-3"
87+
className="px-3 rounded-lg bg-secondary-button dark:bg-secondary-button-dark text-primary dark:text-primary-dark"
8888
onClick={() => {
8989
setIsSubmitted(true);
9090
onSubmit();

src/components/Layout/Page.tsx

+8-8
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ export function Page({children, toc, routeTree, meta, section}: PageProps) {
130130
)}>
131131
{showSidebar && (
132132
<div className="lg:-mt-16">
133-
<div className="lg:pt-16 fixed lg:sticky top-0 start-0 end-0 py-0 shadow lg:shadow-none">
133+
<div className="fixed top-0 py-0 shadow lg:pt-16 lg:sticky start-0 end-0 lg:shadow-none">
134134
<SidebarNav
135135
key={section}
136136
routeTree={routeTree}
@@ -143,7 +143,7 @@ export function Page({children, toc, routeTree, meta, section}: PageProps) {
143143
<Suspense fallback={null}>
144144
<main className="min-w-0 isolate">
145145
<article
146-
className="break-words font-normal text-primary dark:text-primary-dark"
146+
className="font-normal break-words text-primary dark:text-primary-dark"
147147
key={asPath}>
148148
{content}
149149
</article>
@@ -153,14 +153,14 @@ export function Page({children, toc, routeTree, meta, section}: PageProps) {
153153
isHomePage && 'bg-wash dark:bg-gray-95 mt-[-1px]'
154154
)}>
155155
{!isHomePage && (
156-
<div className="mx-auto w-full px-5 sm:px-12 md:px-12 pt-10 md:pt-12 lg:pt-10">
156+
<div className="w-full px-5 pt-10 mx-auto sm:px-12 md:px-12 md:pt-12 lg:pt-10">
157157
{
158-
<hr className="max-w-7xl mx-auto border-border dark:border-border-dark" />
158+
<hr className="mx-auto max-w-7xl border-border dark:border-border-dark" />
159159
}
160160
{showSurvey && (
161161
<>
162-
<div className="flex flex-col items-center m-4 p-4">
163-
<p className="font-bold text-primary dark:text-primary-dark text-lg mb-4">
162+
<div className="flex flex-col items-center p-4 m-4">
163+
<p className="mb-4 text-lg font-bold text-primary dark:text-primary-dark">
164164
How do you like these docs?
165165
</p>
166166
<div>
@@ -178,7 +178,7 @@ export function Page({children, toc, routeTree, meta, section}: PageProps) {
178178
</ButtonLink>
179179
</div>
180180
</div>
181-
<hr className="max-w-7xl mx-auto border-border dark:border-border-dark" />
181+
<hr className="mx-auto max-w-7xl border-border dark:border-border-dark" />
182182
</>
183183
)}
184184
</div>
@@ -193,7 +193,7 @@ export function Page({children, toc, routeTree, meta, section}: PageProps) {
193193
</div>
194194
</main>
195195
</Suspense>
196-
<div className="-mt-16 hidden lg:max-w-xs 2xl:block">
196+
<div className="hidden -mt-16 lg:max-w-custom-xs 2xl:block">
197197
{showToc && toc.length > 0 && <Toc headings={toc} key={asPath} />}
198198
</div>
199199
</div>

src/components/Layout/SidebarNav/SidebarNav.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,12 @@ export default function SidebarNav({
4040
}}>
4141
<aside
4242
className={cn(
43-
`lg:grow flex-col w-full pb-8 lg:pb-0 lg:max-w-xs z-10 hidden lg:block`
43+
`lg:grow flex-col w-full pb-8 lg:pb-0 lg:max-w-custom-xs z-10 hidden lg:block`
4444
)}>
4545
<nav
4646
role="navigation"
4747
style={{'--bg-opacity': '.2'} as React.CSSProperties} // Need to cast here because CSS vars aren't considered valid in TS types (cuz they could be anything)
48-
className="w-full lg:h-auto grow pe-0 lg:pe-5 pt-6 lg:pb-16 md:pt-4 lg:pt-4 scrolling-touch scrolling-gpu">
48+
className="w-full pt-6 scrolling-touch lg:h-auto grow pe-0 lg:pe-5 lg:pb-16 md:pt-4 lg:pt-4 scrolling-gpu">
4949
{/* No fallback UI so need to be careful not to suspend directly inside. */}
5050
<Suspense fallback={null}>
5151
<SidebarRouteTree

src/components/Layout/TopNav/TopNav.tsx

+15-15
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ function Link({
9797
return (
9898
<NextLink
9999
href={`${href}`}
100-
className="inline text-primary dark:text-primary-dark hover:text-link hover:dark:text-link-dark border-b border-link border-opacity-0 hover:border-opacity-100 duration-100 ease-in transition leading-normal"
100+
className="inline leading-normal transition duration-100 ease-in border-b border-opacity-0 text-primary dark:text-primary-dark hover:text-link hover:dark:text-link-dark border-link hover:border-opacity-100"
101101
{...props}>
102102
{children}
103103
</NextLink>
@@ -233,8 +233,8 @@ export default function TopNav({
233233
'duration-300 backdrop-filter backdrop-blur-lg backdrop-saturate-200 transition-shadow bg-opacity-90 items-center w-full flex justify-between bg-wash dark:bg-wash-dark dark:bg-opacity-95 px-1.5 lg:pe-5 lg:ps-4 z-50',
234234
{'dark:shadow-nav-dark shadow-nav': isScrolled || isOpen}
235235
)}>
236-
<div className="h-16 w-full gap-0 sm:gap-3 flex items-center justify-between">
237-
<div className="3xl:flex-1 flex flex-row ">
236+
<div className="flex items-center justify-between w-full h-16 gap-0 sm:gap-3">
237+
<div className="flex flex-row 3xl:flex-1 ">
238238
<button
239239
type="button"
240240
aria-label="Menu"
@@ -247,7 +247,7 @@ export default function TopNav({
247247
)}>
248248
{isOpen ? <IconClose /> : <IconHamburger />}
249249
</button>
250-
<div className="3xl:flex-1 flex align-center">
250+
<div className="flex 3xl:flex-1 align-center">
251251
<NextLink
252252
href="/"
253253
className={`active:scale-95 overflow-hidden transition-transform relative items-center text-primary dark:text-primary-dark p-1 whitespace-nowrap outline-link rounded-full 3xl:rounded-xl inline-flex text-lg font-normal gap-2`}>
@@ -260,16 +260,16 @@ export default function TopNav({
260260
</NextLink>
261261
</div>
262262
</div>
263-
<div className="hidden md:flex flex-1 justify-center items-center w-full 3xl:w-auto 3xl:shrink-0 3xl:justify-center">
263+
<div className="items-center justify-center flex-1 hidden w-full md:flex 3xl:w-auto 3xl:shrink-0 3xl:justify-center">
264264
<button
265265
type="button"
266266
className={cn(
267267
'flex 3xl:w-[56rem] 3xl:mx-0 relative ps-4 pe-1 py-1 h-10 bg-gray-30/20 dark:bg-gray-40/20 outline-none focus:outline-link betterhover:hover:bg-opacity-80 pointer items-center text-start w-full text-gray-30 rounded-full align-middle text-base'
268268
)}
269269
onClick={onOpenSearch}>
270-
<IconSearch className="me-3 align-middle text-gray-30 shrink-0 group-betterhover:hover:text-gray-70" />
270+
<IconSearch className="align-middle me-3 text-gray-30 shrink-0 group-betterhover:hover:text-gray-70" />
271271
Search
272-
<span className="ms-auto hidden sm:flex item-center me-1">
272+
<span className="hidden ms-auto sm:flex item-center me-1">
273273
<Kbd data-platform="mac"></Kbd>
274274
<Kbd data-platform="win" wide>
275275
Ctrl
@@ -301,9 +301,9 @@ export default function TopNav({
301301
<button
302302
aria-label="Search"
303303
type="button"
304-
className="active:scale-95 transition-transform flex md:hidden w-12 h-12 rounded-full items-center justify-center hover:bg-secondary-button hover:dark:bg-secondary-button-dark outline-link"
304+
className="flex items-center justify-center w-12 h-12 transition-transform rounded-full active:scale-95 md:hidden hover:bg-secondary-button hover:dark:bg-secondary-button-dark outline-link"
305305
onClick={onOpenSearch}>
306-
<IconSearch className="align-middle w-5 h-5" />
306+
<IconSearch className="w-5 h-5 align-middle" />
307307
</button>
308308
</div>
309309
<div className="flex dark:hidden">
@@ -313,7 +313,7 @@ export default function TopNav({
313313
onClick={() => {
314314
window.__setPreferredTheme('dark');
315315
}}
316-
className="active:scale-95 transition-transform flex w-12 h-12 rounded-full items-center justify-center hover:bg-primary/5 hover:dark:bg-primary-dark/5 outline-link">
316+
className="flex items-center justify-center w-12 h-12 transition-transform rounded-full active:scale-95 hover:bg-primary/5 hover:dark:bg-primary-dark/5 outline-link">
317317
{darkIcon}
318318
</button>
319319
</div>
@@ -324,7 +324,7 @@ export default function TopNav({
324324
onClick={() => {
325325
window.__setPreferredTheme('light');
326326
}}
327-
className="active:scale-95 transition-transform flex w-12 h-12 rounded-full items-center justify-center hover:bg-primary/5 hover:dark:bg-primary-dark/5 outline-link">
327+
className="flex items-center justify-center w-12 h-12 transition-transform rounded-full active:scale-95 hover:bg-primary/5 hover:dark:bg-primary-dark/5 outline-link">
328328
{lightIcon}
329329
</button>
330330
</div>
@@ -334,7 +334,7 @@ export default function TopNav({
334334
target="_blank"
335335
rel="noreferrer noopener"
336336
aria-label="Open on GitHub"
337-
className="active:scale-95 transition-transform flex w-12 h-12 rounded-full items-center justify-center hover:bg-primary/5 hover:dark:bg-primary-dark/5 outline-link">
337+
className="flex items-center justify-center w-12 h-12 transition-transform rounded-full active:scale-95 hover:bg-primary/5 hover:dark:bg-primary-dark/5 outline-link">
338338
{githubIcon}
339339
</Link>
340340
</div>
@@ -349,13 +349,13 @@ export default function TopNav({
349349
className="overflow-y-scroll isolate no-bg-scrollbar lg:w-[342px] grow bg-wash dark:bg-wash-dark">
350350
<aside
351351
className={cn(
352-
`lg:grow lg:flex flex-col w-full pb-8 lg:pb-0 lg:max-w-xs z-50`,
352+
`lg:grow lg:flex flex-col w-full pb-8 lg:pb-0 lg:max-w-custom-xs z-50`,
353353
isOpen ? 'block z-40' : 'hidden lg:block'
354354
)}>
355355
<nav
356356
role="navigation"
357357
style={{'--bg-opacity': '.2'} as React.CSSProperties} // Need to cast here because CSS vars aren't considered valid in TS types (cuz they could be anything)
358-
className="w-full lg:h-auto grow pe-0 lg:pe-5 pt-4 lg:py-6 md:pt-4 lg:pt-4 scrolling-touch scrolling-gpu">
358+
className="w-full pt-4 scrolling-touch lg:h-auto grow pe-0 lg:pe-5 lg:py-6 md:pt-4 lg:pt-4 scrolling-gpu">
359359
{/* No fallback UI so need to be careful not to suspend directly inside. */}
360360
<Suspense fallback={null}>
361361
<div className="ps-3 xs:ps-5 xs:gap-0.5 xs:text-base overflow-x-auto flex flex-row lg:hidden text-base font-bold text-secondary dark:text-secondary-dark">
@@ -378,7 +378,7 @@ export default function TopNav({
378378
</div>
379379
<div
380380
role="separator"
381-
className="ms-5 mt-4 mb-2 border-b border-border dark:border-border-dark"
381+
className="mt-4 mb-2 border-b ms-5 border-border dark:border-border-dark"
382382
/>
383383
<SidebarRouteTree
384384
// Don't share state between the desktop and mobile versions.

tailwind.config.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,7 @@ module.exports = {
5858
},
5959
maxWidth: {
6060
...defaultTheme.maxWidth,
61-
xs: '21rem',
62-
},
63-
minWidth:{
64-
...defaultTheme.minWidth,
65-
80: '20rem',
61+
'custom-xs': '21rem',
6662
},
6763
outline: {
6864
blue: ['1px auto ' + colors.link, '3px'],

yarn.lock

+18-19
Original file line numberDiff line numberDiff line change
@@ -2601,21 +2601,21 @@ fast-deep-equal@^3.1.1, fast-deep-equal@^3.1.3:
26012601
resolved "https://registry.yarnpkg.com/fast-deep-equal/-/fast-deep-equal-3.1.3.tgz#3a7d56b559d6cbc3eb512325244e619a65c6c525"
26022602
integrity sha512-f3qQ9oQy9j2AhBe/H9VC91wLmKBCCU/gDOnKNAYG5hswO7BLKj09Hc5HYNz9cGI++xlpDCIgDaitVs03ATR84Q==
26032603

2604-
fast-glob@^3.2.12:
2605-
version "3.3.0"
2606-
resolved "https://registry.yarnpkg.com/fast-glob/-/fast-glob-3.3.0.tgz#7c40cb491e1e2ed5664749e87bfb516dbe8727c0"
2607-
integrity sha512-ChDuvbOypPuNjO8yIDf36x7BlZX1smcUMTTcyoIjycexOxd6DFsKsg21qVBzEmr3G7fUKIRy2/psii+CIUt7FA==
2604+
fast-glob@^3.2.9:
2605+
version "3.2.11"
2606+
resolved "https://registry.yarnpkg.com/fast-glob/-/fast-glob-3.2.11.tgz#a1172ad95ceb8a16e20caa5c5e56480e5129c1d9"
2607+
integrity sha512-xrO3+1bxSo3ZVHAnqzyuewYT6aMFHRAd4Kcs92MAonjwQZLsK9d0SF1IyQ3k5PoirxTW0Oe/RqFgMQ6TcNE5Ew==
26082608
dependencies:
26092609
"@nodelib/fs.stat" "^2.0.2"
26102610
"@nodelib/fs.walk" "^1.2.3"
26112611
glob-parent "^5.1.2"
26122612
merge2 "^1.3.0"
26132613
micromatch "^4.0.4"
26142614

2615-
fast-glob@^3.2.9:
2616-
version "3.2.11"
2617-
resolved "https://registry.yarnpkg.com/fast-glob/-/fast-glob-3.2.11.tgz#a1172ad95ceb8a16e20caa5c5e56480e5129c1d9"
2618-
integrity sha512-xrO3+1bxSo3ZVHAnqzyuewYT6aMFHRAd4Kcs92MAonjwQZLsK9d0SF1IyQ3k5PoirxTW0Oe/RqFgMQ6TcNE5Ew==
2615+
fast-glob@^3.3.0:
2616+
version "3.3.2"
2617+
resolved "https://registry.yarnpkg.com/fast-glob/-/fast-glob-3.3.2.tgz#a904501e57cfdd2ffcded45e99a54fef55e46129"
2618+
integrity sha512-oX2ruAFQwf/Orj8m737Y5adxDQO0LAB7/S5MnxCdTNDd4p6BsyIVsv9JQsATbTSq8KHRpLwIHbVlUNatxd+1Ow==
26192619
dependencies:
26202620
"@nodelib/fs.stat" "^2.0.2"
26212621
"@nodelib/fs.walk" "^1.2.3"
@@ -3371,10 +3371,10 @@ isexe@^2.0.0:
33713371
resolved "https://registry.yarnpkg.com/isexe/-/isexe-2.0.0.tgz#e8fbf374dc556ff8947a10dcb0572d633f2cfa10"
33723372
integrity sha1-6PvzdNxVb/iUehDcsFctYz8s+hA=
33733373

3374-
jiti@^1.18.2:
3375-
version "1.20.0"
3376-
resolved "https://registry.yarnpkg.com/jiti/-/jiti-1.20.0.tgz#2d823b5852ee8963585c8dd8b7992ffc1ae83b42"
3377-
integrity sha512-3TV69ZbrvV6U5DfQimop50jE9Dl6J8O1ja1dvBbMba/sZ3YBEQqJ2VZRoQPVnhlzjNtU1vaXRZVrVjU4qtm8yA==
3374+
jiti@^1.19.1:
3375+
version "1.21.0"
3376+
resolved "https://registry.yarnpkg.com/jiti/-/jiti-1.21.0.tgz#7c97f8fe045724e136a397f7340475244156105d"
3377+
integrity sha512-gFqAIbuKyyso/3G2qhiO2OM6shY6EPP/R0+mkDbyspxKazh8BXDC5FiFsUjlczgdNz/vfra0da2y+aHrusLG/Q==
33783378

33793379
"js-tokens@^3.0.0 || ^4.0.0", js-tokens@^4.0.0:
33803380
version "4.0.0"
@@ -6103,20 +6103,20 @@ table@^6.0.9:
61036103
string-width "^4.2.3"
61046104
strip-ansi "^6.0.1"
61056105

6106-
tailwindcss@^3.3.2:
6107-
version "3.3.2"
6108-
resolved "https://registry.yarnpkg.com/tailwindcss/-/tailwindcss-3.3.2.tgz#2f9e35d715fdf0bbf674d90147a0684d7054a2d3"
6109-
integrity sha512-9jPkMiIBXvPc2KywkraqsUfbfj+dHDb+JPWtSJa9MLFdrPyazI7q6WX2sUrm7R9eVR7qqv3Pas7EvQFzxKnI6w==
6106+
tailwindcss@^3.4.1:
6107+
version "3.4.1"
6108+
resolved "https://registry.yarnpkg.com/tailwindcss/-/tailwindcss-3.4.1.tgz#f512ca5d1dd4c9503c7d3d28a968f1ad8f5c839d"
6109+
integrity sha512-qAYmXRfk3ENzuPBakNK0SRrUDipP8NQnEY6772uDhflcQz5EhRdD7JNZxyrFHVQNCwULPBn6FNPp9brpO7ctcA==
61106110
dependencies:
61116111
"@alloc/quick-lru" "^5.2.0"
61126112
arg "^5.0.2"
61136113
chokidar "^3.5.3"
61146114
didyoumean "^1.2.2"
61156115
dlv "^1.1.3"
6116-
fast-glob "^3.2.12"
6116+
fast-glob "^3.3.0"
61176117
glob-parent "^6.0.2"
61186118
is-glob "^4.0.3"
6119-
jiti "^1.18.2"
6119+
jiti "^1.19.1"
61206120
lilconfig "^2.1.0"
61216121
micromatch "^4.0.5"
61226122
normalize-path "^3.0.0"
@@ -6128,7 +6128,6 @@ tailwindcss@^3.3.2:
61286128
postcss-load-config "^4.0.1"
61296129
postcss-nested "^6.0.1"
61306130
postcss-selector-parser "^6.0.11"
6131-
postcss-value-parser "^4.2.0"
61326131
resolve "^1.22.2"
61336132
sucrase "^3.32.0"
61346133

0 commit comments

Comments
 (0)