Add support for React & Node 18 (as easy as adding startTransition() on each setState)

[AnderUstarroz]

Summary:

Current react modal doesn't work with latest version of React + Node v18

Steps to reproduce:

1. Use react-modal with latest React's and Node v18

Expected behavior:

Should work normally

Example of issue:

Breaks with the following error message:

Solution:

Simply add startTransition() wrapping each of the calls for setting the state.
startTransition(() => setState("something))

[multivoltage]

do you think someone supports this library?

[diasbruno]

@AnderUstarroz It seems easy. Would you like to make a contribution?

[multivoltage]

@AnderUstarroz can you provide an eample? I installed correctly a basic example with react 18 yesterday

[diasbruno]

@multivoltage Would you like to make a contribution?

[diasbruno]

Maybe it's related to the weird <suspense /> component.

Probably, something like this:

<suspense fallback="...">
  <modal />
</suspense>

will trigger this behavior.

[diasbruno]

I'm guessing to fix this isse the solution is to wrap the setIsOpen() (how people call it). But it's application specific, so we don't break older reaect versions.

function toggleModal() {
    startTransition(() => {
      setIsOpen(!isOpen);      
    });
}

[itsjesusmacias]

Is it only necessary to set setIsOpen? I would like to be able to carry out this task to contribute to the project

[multivoltage]

@diasbruno yes but as I said before in my example all work great so...
@itsjesusmacias yes but using start-transiction means a major release since startTransition is only react > 18

[diasbruno]

Thanks, @multivoltage.
@itsjesusmacias Give it a try...I'm hoping something like this would help, otherwise we need to investigate further this issue.

As @multivoltage said, this feature it released on react 18+, so if we need to make a fix for it, we need to be careful to not break for older versions.

[multivoltage]

Maybe we can add "peerDependencies" react >=18 ?