-
Notifications
You must be signed in to change notification settings - Fork 22
Open
Labels
2024 UpdateNew discussions, issues and requests triggered by the 2024 updateNew discussions, issues and requests triggered by the 2024 updateDiscussionProposed solutionIssues or feature requests with a solution in reachIssues or feature requests with a solution in reachfeedback required
Description
We removed day mode since it was confusing in the new theming system of version 2, given the flag was non-functional and day mode simply set default colors.
While implementing version 2 in Readium/Thorium, we noticed that we would probably not be using these modes in the various toolkits and apps, but use presets of the theming custom properties. In Thorium Web for instance we are just using the colors that are exposed through json, and extend theming from that because we need far more. So we are not using the flag any longer in the Preferences API.
This raises the question whether we should not remove these modes entirely, as they would only be present in version 2 out of courtesy as consumers that may not be even using them.
Metadata
Metadata
Assignees
Labels
2024 UpdateNew discussions, issues and requests triggered by the 2024 updateNew discussions, issues and requests triggered by the 2024 updateDiscussionProposed solutionIssues or feature requests with a solution in reachIssues or feature requests with a solution in reachfeedback required