Skip to content

Commit 665d6f8

Browse files
authored
Remove Jetifier (#610)
1 parent ef0a4f5 commit 665d6f8

31 files changed

+8
-15
lines changed

CHANGELOG.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,12 @@ All notable changes to this project will be documented in this file. Take a look
44

55
**Warning:** Features marked as *experimental* may change or be removed in a future release without notice. Use with caution.
66

7-
<!-- ## [Unreleased] -->
7+
## [Unreleased]
8+
9+
### Changed
10+
11+
* Jetifier is not required anymore, you can remove `android.enableJetifier=true` from your `gradle.properties` if you were using Readium as a local clone.
12+
813

914
## [3.0.3]
1015

README.md

-6
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,6 @@ First, add the repository as a Git submodule of your app repository, then checko
5656
git submodule add https://github.com/readium/kotlin-toolkit.git
5757
```
5858

59-
Make sure you have Jetifier enabled in your `gradle.properties` file:
60-
61-
```properties
62-
android.enableJetifier=true
63-
```
64-
6559
Then, include the Readium build to your project's `settings.gradle` file. The Readium dependencies will automatically build against the local sources.
6660

6761
```groovy

gradle.properties

-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ org.gradle.jvmargs=-Xmx2048m -Dfile.encoding=UTF-8
2323
# Android operating system, and which are packaged with your app"s APK
2424
# https://developer.android.com/topic/libraries/support-library/androidx-rn
2525
android.useAndroidX=true
26-
# Automatically convert third-party libraries to use AndroidX
27-
android.enableJetifier=true
2826
# Kotlin code style for this project: "official" or "obsolete":
2927
kotlin.code.style=official
3028

gradle/libs.versions.toml

-4
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,6 @@ ktlint = "12.1.1"
5454
# We cannot upgrade to 1.9.0 as it conflicts with liblcp.
5555
# See https://github.com/readium/kotlin-toolkit/issues/29
5656
#noinspection GradleDependency
57-
pdfium = "1.8.2"
58-
pdf-viewer = "2.8.2"
59-
#noinspection GradleDependency
6057
picasso = "2.8"
6158
pspdfkit = "8.4.1"
6259

@@ -119,7 +116,6 @@ kotlinx-coroutines-test = { group = "org.jetbrains.kotlinx", name = "kotlinx-cor
119116
kotlinx-datetime = { group = "org.jetbrains.kotlinx", name = "kotlinx-datetime", version.ref = "kotlinx-datetime" }
120117
kotlinx-serialization-json = { group = "org.jetbrains.kotlinx", name = "kotlinx-serialization-json", version.ref = "kotlinx-serialization-json" }
121118

122-
pdfium = { group = "com.github.barteksc", name = "pdfium-android", version.ref="pdfium" }
123119
picasso = { group = "com.squareup.picasso", name = "picasso", version.ref = "picasso" }
124120
pspdfkit = { group = "com.pspdfkit", name = "pspdfkit", version.ref ="pspdfkit" }
125121

readium/adapters/pdfium/document/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ android {
1414

1515
dependencies {
1616
api(project(":readium:readium-shared"))
17+
implementation(files("../libs/pdfium-android-1.8.2.jar"))
1718

18-
implementation(libs.pdfium)
1919
implementation(libs.timber)
2020
implementation(libs.kotlinx.coroutines.android)
2121
}
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

readium/adapters/pdfium/navigator/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ dependencies {
2121
api(project(":readium:readium-shared"))
2222
api(project(":readium:readium-navigator"))
2323
api(project(":readium:adapters:pdfium:readium-adapter-pdfium-document"))
24+
implementation(files("../libs/pdfium-android-1.8.2.jar"))
2425
implementation(files("libs/android-pdf-viewer-2.8.2.jar"))
2526

2627
implementation(libs.androidx.fragment.ktx)
27-
implementation(libs.pdfium)
2828
implementation(libs.timber)
2929
implementation(libs.kotlinx.coroutines.android)
3030
implementation(libs.kotlinx.serialization.json)

0 commit comments

Comments
 (0)