Skip to content

Conversation

@bashleigh
Copy link
Contributor

Pull request checklist

Detail as per issue below (required):

fixes: #10709

Small issue with page size, cannot fetch more than 999 per page. Not sure if there's a query param to increase it or whether I need to paginate the request to get all users for the download.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

} catch (error) {
logger(error as Error)
}
setCsvLoading(false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a finally for this?

<>
<BodyText>Total Users: {users?.totalCount}</BodyText>
<ButtonGroup>
<Button intent="primary" loading={csvLoading} disabled={csvLoading} onClick={() => downloadAsCSV()}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just pass downloadAsCSV to the on click right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide CSV on RC Service App

3 participants