[ci] merge jobs, add finalise check, bump to PHP 8.3 (#358)

* [ci] merge jobs

* misc

* bump to PHP 8.3

Author: TomasVotruba

.github/workflows/code_analysis.yaml

@@ -16,24 +16,41 @@ jobs:
             fail-fast: false
             matrix:
                 actions:
-                    -
-                        name: 'Active Classes'
-                        run: vendor/bin/class-leak check config src rules
                     -
                         name: "Validate docs"
                         run: vendor/bin/rule-doc-generator validate src rules
 
+                    -
+                        name: 'Active Classes'
+                        run: vendor/bin/class-leak check config src rules --ansi --skip-suffix "Rector" --skip-type "\Rector\Set\Contract\SetProviderInterface"
+
+                    -
+                        name: "Finalize Classes"
+                        run: vendor/bin/swiss-knife finalize config src tests rules rules-tests --ansi
+
+                    -
+                        name: 'Composer Validate'
+                        run: composer validate
+
+                    -
+                        name: 'PHPStan'
+                        run: vendor/bin/phpstan
+
+                    -
+                        name: 'Tests'
+                        run: vendor/bin/phpunit
+
         name: ${{ matrix.actions.name }}
         runs-on: ubuntu-latest
-        timeout-minutes: 10
+        timeout-minutes: 3
 
         steps:
             -   uses: actions/checkout@v4
 
             -
                 uses: shivammathur/setup-php@v2
                 with:
-                    php-version: 8.2
+                    php-version: 8.3
                     coverage: none
 
             -   uses: "ramsey/composer-install@v2"

.github/workflows/code_analysis_reusable.yaml

@@ -0,0 +1,39 @@
+# github action that checks code with Rector
+name: Rector
+
+on:
+    pull_request: null
+
+env:
+    # see https://github.com/composer/composer/issues/9368#issuecomment-718112361
+    COMPOSER_ROOT_VERSION: "dev-main"
+
+jobs:
+    rector:
+        runs-on: ubuntu-latest
+        if: github.event.pull_request.head.repo.full_name == 'rectorphp/rector-downgrade-php'
+        steps:
+            -
+                if: github.event.pull_request.head.repo.full_name == github.repository
+                uses: actions/checkout@v4
+                with:
+                    # Must be used to trigger workflow after push
+                    token: ${{ secrets.ACCESS_TOKEN }}
+
+            -
+                uses: shivammathur/setup-php@v2
+                with:
+                    php-version: 8.3
+                    coverage: none
+
+            -   uses: "ramsey/composer-install@v2"
+
+            -   run: vendor/bin/rector --ansi
+
+            -
+                # commit only to core contributors who have repository access
+                uses: stefanzweifel/git-auto-commit-action@v4
+                with:
+                    commit_message: '[rector] Rector fixes'
+                    commit_author: 'GitHub Action <actions@github.com>'
+                    commit_user_email: 'action@github.com'

.github/workflows/rector.yaml

@@ -4,22 +4,25 @@
     "license": "MIT",
     "description": "Rector downgrade PHP rules",
     "require": {
-        "php": ">=8.2"
+        "php": ">=8.3"
     },
     "require-dev": {
-        "phpstan/extension-installer": "^1.3",
-        "phpstan/phpstan": "^2.1.32",
+        "phpstan/extension-installer": "^1.4",
+        "phpstan/phpstan": "^2.1.33",
         "phpstan/phpstan-webmozart-assert": "^2.0",
         "phpunit/phpunit": "^11.5",
+        "rector/jack": "^0.5.1",
         "rector/rector-src": "dev-main",
+        "rector/swiss-knife": "^2.3",
         "rector/type-perfect": "^2.1",
-        "symplify/easy-coding-standard": "^12.3",
+        "symplify/easy-coding-standard": "^13.0",
         "symplify/phpstan-extensions": "^12.0",
         "symplify/phpstan-rules": "^14.9",
         "symplify/rule-doc-generator": "^12.2",
         "symplify/vendor-patches": "^11.5",
-        "tomasvotruba/class-leak": "^1.0",
-        "tracy/tracy": "^2.10"
+        "tomasvotruba/class-leak": "^2.1",
+        "tomasvotruba/unused-public": "^2.2",
+        "tracy/tracy": "^2.11"
     },
     "autoload": {
         "psr-4": {

.github/workflows/tests.yaml

@@ -10,13 +10,14 @@
 
 return RectorConfig::configure()
     ->withImportNames(removeUnusedImports: true)
-    ->withPhpSets(php82: true)
+    ->withPhpSets()
     ->withComposerBased(phpunit: true)
     ->withPreparedSets(
         deadCode: true,
         codeQuality: true,
         codingStyle: true,
         typeDeclarations: true,
+        typeDeclarationDocblocks: true,
         privatization: true,
         naming: true,
         earlyReturn: true,

composer.json

@@ -4,7 +4,7 @@
 
 namespace Rector\Tests\DowngradePhp72\Rector\ClassMethod\DowngradeParameterTypeWideningRector\Source;
 
-class ParentNullableString
+final class ParentNullableString
 {
     public function load(string $value = null)
     {

rector.php

@@ -4,7 +4,7 @@
 namespace Rector\Tests\DowngradePhp72\Rector\FunctionLike\DowngradeObjectTypeDeclarationRector\Source;
 
 
-class AnotherClass
+final class AnotherClass
 {
 
 }

rules-tests/DowngradePhp72/Rector/ClassMethod/DowngradeParameterTypeWideningRector/Source/ParentNullableString.php

@@ -4,6 +4,6 @@
 
 namespace Rector\Tests\DowngradePhp74\Rector\ArrowFunction\ArrowFunctionToAnonymousFunctionRector\Source;
 
-class Foo {
+final class Foo {
     public $bar = 1;
 }

rules-tests/DowngradePhp72/Rector/FunctionLike/DowngradeObjectTypeDeclarationRector/Source/AnotherClass.php

@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\DowngradePhp74\Rector\Property\DowngradeTypedPropertyRector\Source;
 
-class AnotherClass
+final class AnotherClass
 {
 
 }