@@ -225,20 +225,21 @@ def test_select_changed_targets_dockerfile(self):
225225 def test_select_changed_targets_shared_file (self ):
226226 targets = extract_image_targets (makefile_dir = project_dir )
227227
228- changed_files = ["cuda/ubi9-python-3.11/NGC-DL-CONTAINER-LICENSE " ]
228+ changed_files = ["jupyter/utils/install_pdf_deps.sh " ]
229229
230- # With the removal of chained builds - which now potentially has multiple Dockerfiles defined in a given
231- # directory, there is an inefficiency introduced to 'gha_pr_changed_files' as demonstrated by this unit test.
232- # Even though this test only changes a (shared) CUDA file - you will notice the 'cpu' and 'rocm' targets
233- # also being returned. Odds of this inefficiency noticably "hurting us" is low - so of the opinion we can
234- # simply treat this as technical debt.
230+ # With multiple Dockerfile.konflux.* files per directory, should_build_target scans
231+ # every Konflux Dockerfile in a build directory for buildinputs dependencies. A shared
232+ # jupyter/utils change therefore fans out to CPU, CUDA, and ROCm targets (not just CUDA).
235233 targets = gha_pr_changed_files .filter_out_unchanged (targets , changed_files )
236234 assert set (targets ) == {
237- "jupyter-minimal-ubi9-python-3.11" ,
238- "cuda-jupyter-minimal-ubi9-python-3.11" ,
239- "cuda-jupyter-pytorch-ubi9-python-3.11" ,
240- "runtime-cuda-pytorch-ubi9-python-3.11" ,
241- "cuda-jupyter-tensorflow-ubi9-python-3.11" ,
242- "rocm-jupyter-minimal-ubi9-python-3.11" ,
243- "runtime-cuda-tensorflow-ubi9-python-3.11" ,
235+ "jupyter-minimal-ubi9-python-3.12" ,
236+ "jupyter-datascience-ubi9-python-3.12" ,
237+ "jupyter-trustyai-ubi9-python-3.12" ,
238+ "cuda-jupyter-minimal-ubi9-python-3.12" ,
239+ "cuda-jupyter-pytorch-ubi9-python-3.12" ,
240+ "cuda-jupyter-pytorch-llmcompressor-ubi9-python-3.12" ,
241+ "cuda-jupyter-tensorflow-ubi9-python-3.12" ,
242+ "rocm-jupyter-minimal-ubi9-python-3.12" ,
243+ "rocm-jupyter-pytorch-ubi9-python-3.12" ,
244+ "rocm-jupyter-tensorflow-ubi9-python-3.12" ,
244245 }
0 commit comments