Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed nexus waiting to https #364

Closed
wants to merge 1 commit into from
Closed

Conversation

bvkin
Copy link
Contributor

@bvkin bvkin commented Apr 16, 2019

What does this PR do?

When waiting for nexus to appear after it's configuration, the config-nexus role would use http instead of https. This corrects it.

How should this be tested?

Use this role and ensure that it doesn't fail on the "Ensure the Nexus Server is Up" step.

Is there a relevant Issue open for this?

resolves #362

Other Relevant info, PRs, etc.

Please provide link to other PRs that may be related (blocking, resolves, etc. etc.)

People to notify

cc: @redhat-cop/infra-ansible

Copy link
Contributor

@tylerauerbeck tylerauerbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So as much as I think and want everything to be on https all the time, isn't it still feasible that someone, somewhere will be running nexus on http? To keep this flexible, could we just have a variable ( nexus_protocol?) that we could set and default it to https? Hard coding it just feels like kicking the problem down the road (in the other direction) for us to solve if this would pop up for http.

@oybed
Copy link
Contributor

oybed commented Apr 16, 2019

This PR (and corresponding issue) was strictly to just get alignment between the wait-for-nexus and the configure-repos. However, Deven has a bigger PR open to correct this in the right way #346 - While waiting for that, we can "temporarily" fix it locally instead of in PR #364 for now.

@tylerauerbeck
Copy link
Contributor

Ahh. Alright that makes more sense. I'll try to see if I can get #346 reviewed so we can get that merged in.

@oybed
Copy link
Contributor

oybed commented Apr 19, 2019

Considering #346 and #365, I believe we can close this PR as the #365 should fix the current issue and #364 have overall improvements going forward

@oybed oybed closed this Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config-nexus uses http instead of https for "wait-for-nexus"
3 participants