PodPreset needs to be in the same name space as the pod?

[jmozd]

While debugging a fresh podpreset-webhook setup, I noticed that the name space of the PodPreset object seems relevant when deciding to which pods it is applicable.

I created a PodPreset with no "namespace" setting:

apiVersion: redhatcop.redhat.io/v1alpha1
kind: PodPreset
metadata:
  name: presettest
spec:
  env:
  - name: SOMEVAR
    value: "somevalue"
  selector:

and verified the variable got applied to a test pod I created (the pod ended up in the "default" name space). Newly created pods in the "kube-system" name space did not have SOMEVAR injected and I traced that down to filterPodPresets() returning an empty list.

Once I created another instance of PodPreset, in the "kube-system" name space, the injection also worked for newly created pods in the "kube-system" name space.

1. do I see this correctly, or did I simply mess up my config?
2. if that's how it works, I'd love to see it mentioned in README.md
3. is there a way to actually configure a PodPreset to apply to every name space?

[sabre1041]

@jmozd Yes, PodPreset's are namespace scoped and apply to only resources within the namespace

[jmozd]

@sabre1041 Thank you for the confirmation. Any (easy) way to change that, within the code? I'm looking for a way to set "global defaults".

[X-dark]

@sabre1041 Any reason why this behavior was changed? This used to work fine. I am not sure to find which commit changed that either.

[X-dark]

Reverting that commit 1218048 make things work. Not sure why it was not working back in April though as commit was in June...

[jmozd]

@sabre1041 Would it be acceptable if I create a PR that will fall back to checking for PodPresets in the old fashion?

• try to load PodPresets from the request's namespace
• if that fails, try to load PodPresets without namespace
• if that fails, too: bail out