Skip to content

Commit 61468ca

Browse files
authored
fix: remove redundant check and fix typo in pr-podman-push (#3361)
Signed-off-by: Frank Kong <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
1 parent 26709a8 commit 61468ca

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/pr-podman-push.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
echo "PR branch: $PR_BRANCH"
4444
echo "Artifact Name: container-image-pr-$PR_NUMBER-$SHORT_SHA"
4545
46-
echo "pr-number=$PR_NUMBER" >> $GITHUB_OUTPUT
46+
echo "pr_number=$PR_NUMBER" >> $GITHUB_OUTPUT
4747
echo "short-sha=$SHORT_SHA" >> $GITHUB_OUTPUT
4848
echo "artifact-name=container-image-pr-$PR_NUMBER-$SHORT_SHA" >> $GITHUB_OUTPUT
4949
else
@@ -53,7 +53,7 @@ jobs:
5353
- name: Determine artifact name
5454
run: |
5555
# For workflow_run, extract from the event context
56-
BUILD_ID="${{ steps.get-pr-info.outputs.pr-number }}"
56+
BUILD_ID="${{ steps.get-pr-info.outputs.pr_number }}"
5757
SHORT_SHA="${{ github.event.workflow_run.head_sha }}"
5858
SHORT_SHA="${SHORT_SHA:0:8}"
5959
@@ -140,7 +140,7 @@ jobs:
140140
echo "(either due to [skip-build] tag or no relevant changes with existing image)"
141141
142142
- name: Comment the image pull link
143-
if: ${{ steps.check-skip.outputs.is_skipped != 'true' && github.event_name == 'workflow_run' && steps.get-pr-info.outputs.pr_number }}
143+
if: ${{ steps.check-skip.outputs.is_skipped != 'true' }}
144144
uses: actions/github-script@v7
145145
env:
146146
PUSHED_TAGS: ${{ steps.prepare.outputs.tags }}

0 commit comments

Comments
 (0)