Skip to content

Commit c1969a0

Browse files
authored
fix(e2e): topology fix (#3348)
* topology fix * topology fix * topology fix * topology fix * topology fix * topology fix * topology fix * topology fix
1 parent c44f03b commit c1969a0

File tree

2 files changed

+13
-14
lines changed

2 files changed

+13
-14
lines changed

e2e-tests/playwright/e2e/plugins/topology/topology.spec.ts

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,15 @@ test.describe("Test Topology Plugin", () => {
4141
await uiHelper.clickTab("Topology");
4242
await uiHelper.verifyText("backstage-janus");
4343
await page.getByRole("button", { name: "Fit to Screen" }).click();
44+
await page
45+
.locator('[data-test-id="topology-test"]')
46+
.getByTestId(/(status-error|status-ok)/)
47+
.first()
48+
.click();
49+
await uiHelper.verifyDivHasText(
50+
/Pipeline (Succeeded|Failed|Cancelled|Running)/,
51+
);
52+
await uiHelper.verifyDivHasText(/\d+ (Succeeded|Failed|Cancelled|Running)/);
4453
await topology.verifyDeployment("topology-test");
4554
await uiHelper.verifyButtonURL("Open URL", "topology-test-route", {
4655
locator: `[data-test-id="topology-test"]`,
@@ -72,9 +81,11 @@ test.describe("Test Topology Plugin", () => {
7281
await page.getByLabel("Pod count").click();
7382
await uiHelper.verifyText("1");
7483
await uiHelper.verifyText("Pod");
84+
7585
// await topology.hoverOnPodStatusIndicator();
7686
// await uiHelper.verifyTextInTooltip("Running");
7787
// await uiHelper.verifyText("1Running");
88+
7889
await uiHelper.verifyButtonURL(
7990
"Edit source code",
8091
"https://github.com/janus-idp/backstage-showcase",
@@ -91,19 +102,7 @@ test.describe("Test Topology Plugin", () => {
91102
await uiHelper.verifyHeading("PipelineRuns");
92103
await uiHelper.verifyText("PL");
93104
await uiHelper.verifyText("PLR");
94-
// await expect(async () => {
95-
// await page.getByTestId("status-ok").first().click({
96-
// force: true,
97-
// timeout: 30000,
98-
// });
99-
// }).toPass({
100-
// timeout: 30000,
101-
// intervals: [1000, 2000, 3000],
102-
// });
103-
// await uiHelper.verifyDivHasText(
104-
// /Pipeline (Succeeded|Failed|Cancelled|Running)Task/,
105-
// );
106-
// await uiHelper.verifyText(/Pipeline (Succeeded|Failed|Cancelled|Running)/);
105+
await uiHelper.verifyText(/(Succeeded|Failed|Cancelled|Running)/);
107106
});
108107
});
109108

e2e-tests/playwright/support/pages/topology.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export class Topology {
1414
async hoverOnPodStatusIndicator() {
1515
const locator = this.page
1616
.locator('[data-test-id="topology-test"]')
17-
.getByText("1")
17+
.getByText("1Pod")
1818
.first();
1919
await locator.hover();
2020
await this.page.waitForTimeout(1000);

0 commit comments

Comments
 (0)