-
Notifications
You must be signed in to change notification settings - Fork 211
[release-1.7] chore(e2e): skip bulk import on PR checks (backport #3596) #3749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.7
Are you sure you want to change the base?
[release-1.7] chore(e2e): skip bulk import on PR checks (backport #3596) #3749
Conversation
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The image is available at: |
|
New changes are detected. LGTM label has been removed. |
|
The image is available at: |
670ecf6 to
2b6b801
Compare
|
/test e2e-ocp-helm |
|
You are above your monthly Qodo Merge usage quota. If you are a paying user, please link your GitHub/GitLab/Bitbucket account with your qodo account here to claim your seat. To allow usage organization-wide without linking, please reach to Qodo. |
|
/test e2e-ocp-helm |
|
You are above your monthly Qodo Merge usage quota. If you are a paying user, please link your GitHub/GitLab/Bitbucket account with your qodo account here to claim your seat. To allow usage organization-wide without linking, please reach to Qodo. |
|
/test e2e-ocp-helm |
|
You are above your monthly Qodo Merge usage quota. If you are a paying user, please link your GitHub/GitLab/Bitbucket account with your qodo account here to claim your seat. To allow usage organization-wide without linking, please reach to Qodo. |
09bb439 to
02df2a4
Compare
|
The image is available at: |
Based on OpenShift CI Prow configuration analysis, JOB_TYPE is the correct variable to detect presubmit jobs (PR checks). Reference: ci-operator/step-registry/redhat-developer/rhdh/ocp/helm/refactored/redhat-developer-rhdh-ocp-helm-refactored-commands.sh:85
Use multiple conditions to detect PR checks: - JOB_TYPE === 'presubmit' (Prow standard) - PULL_NUMBER exists (fallback) - JOB_NAME contains 'pull-ci-' (job name pattern) Added debug logs to troubleshoot environment variable availability.
Based on actual CI logs, JOB_TYPE and PULL_NUMBER are NOT available in the Playwright test environment. However, JOB_NAME IS available and contains 'pull-ci-' for all PR check jobs. Example from logs: JOB_NAME: pull-ci-redhat-developer-rhdh-release-1.7-e2e-ocp-helm This is the most reliable way to detect PR checks in this environment.
f07b584 to
f01af80
Compare
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/review |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Summary
This PR backports the changes from #3596 to
release-1.7to skip the Bulk Import test during PR checks (presubmit jobs) and limit execution to OCP jobs only to avoid GitHub API rate limiting.Related Issue
Changes Made
Skip Bulk Import Test on PR Checks
Added conditional skips to
bulk-import.spec.ts:Why these changes:
presubmit) - Bulk Import tests require GitHub API access and can hit rate limits during PR validationTesting
Before
After
Cherry-pick Details
This is a clean backport of commit
e2f3dfe3from #3596 to therelease-1.7branch.Original commit:
e2f3dfe3caf1be384640e50a190f9295c0c06ab5Author: Zbyněk Drápela (@zdrapela)
Date: Oct 21, 2025
The changes were applied manually to avoid merge conflicts since the file structure differs slightly between
mainandrelease-1.7.Verification Steps
1. PR Checks
2. OCP Nightly Jobs
3. Other K8s Jobs
Impact
Checklist
Additional Notes
Why This Backport is Needed
The
release-1.7branch was experiencing issues with:This backport brings the same improvements that were applied to
mainvia #3596.Differences from Original PR
The original PR #3596 also included changes to Quay tests, but those are not included in this backport as they are not relevant to
release-1.7.This PR only includes:
Original PR #3596 also included (not in this backport):
Files Changed:
e2e-tests/playwright/e2e/plugins/bulk-import.spec.ts(4 insertions)Total: 1 file changed, 4 insertions(+)