refactor: resolve pull requet comments

- remove fixed timeouts causing flaky results sometimes
- export common logic for building string buffers and reuse it, as a helper function
- cleanup unncesessary helper frunction in the browser objects

Author: valkirilov

tests/playwright/helpers/api/api-keys.ts

@@ -7,6 +7,7 @@ import {
     SetKeyParameters,
     StreamKeyParameters,
 } from '../../types'
+import { stringToBuffer } from '../utils'
 
 const bufferPathMask = '/databases/databaseId/keys?encoding=buffer'
 export class APIKeyRequests {
@@ -23,8 +24,8 @@ export class APIKeyRequests {
             databaseParameters.databaseName,
         )
         const requestBody = {
-            keyName: Buffer.from(keyParameters.keyName, 'utf-8'),
-            value: Buffer.from(keyParameters.value, 'utf-8'),
+            keyName: stringToBuffer(keyParameters.keyName),
+            value: stringToBuffer(keyParameters.value),
             expire: keyParameters?.expire,
         }
 
@@ -46,11 +47,11 @@ export class APIKeyRequests {
             databaseParameters.databaseName,
         )
         const requestBody = {
-            keyName: Buffer.from(keyParameters.keyName, 'utf-8'),
+            keyName: stringToBuffer(keyParameters.keyName),
             fields: keyParameters.fields.map((fields) => ({
                 ...fields,
-                field: Buffer.from(fields.field, 'utf-8'),
-                value: Buffer.from(fields.value, 'utf-8'),
+                field: stringToBuffer(fields.field),
+                value: stringToBuffer(fields.value),
             })),
             expire: keyParameters?.expire,
         }
@@ -70,9 +71,9 @@ export class APIKeyRequests {
             databaseParameters.databaseName,
         )
         const requestBody = {
-            keyName: Buffer.from(keyParameters.keyName, 'utf-8'),
+            keyName: stringToBuffer(keyParameters.keyName),
             elements: keyParameters.elements.map((element) =>
-                Buffer.from(element, 'utf-8'),
+                stringToBuffer(element),
             ),
             expire: keyParameters?.expire,
         }
@@ -95,12 +96,12 @@ export class APIKeyRequests {
             databaseParameters.databaseName,
         )
         const requestBody = {
-            keyName: Buffer.from(keyParameters.keyName, 'utf-8'),
+            keyName: stringToBuffer(keyParameters.keyName),
             entries: keyParameters.entries.map((member) => ({
                 ...member,
                 fields: member.fields.map(({ name, value }) => ({
-                    name: Buffer.from(name, 'utf-8'),
-                    value: Buffer.from(value, 'utf-8'),
+                    name: stringToBuffer(name),
+                    value: stringToBuffer(value),
                 })),
             })),
             expire: keyParameters?.expire,
@@ -121,9 +122,9 @@ export class APIKeyRequests {
             databaseParameters.databaseName,
         )
         const requestBody = {
-            keyName: Buffer.from(keyParameters.keyName, 'utf-8'),
+            keyName: stringToBuffer(keyParameters.keyName),
             members: keyParameters.members.map((member) =>
-                Buffer.from(member, 'utf-8'),
+                stringToBuffer(member),
             ),
             expire: keyParameters?.expire,
         }
@@ -147,9 +148,9 @@ export class APIKeyRequests {
             databaseParameters.databaseName,
         )
         const requestBody = {
-            keyName: Buffer.from(keyParameters.keyName, 'utf-8'),
+            keyName: stringToBuffer(keyParameters.keyName),
             members: keyParameters.members.map((member) => ({
-                name: Buffer.from(member.name, 'utf-8'),
+                name: stringToBuffer(member.name),
                 score: member.score,
             })),
             expire: keyParameters?.expire,
@@ -173,7 +174,7 @@ export class APIKeyRequests {
             databaseParameters.databaseName,
         )
         const requestBody: any = {
-            keyName: Buffer.from(keyParameters.keyName, 'utf-8'),
+            keyName: stringToBuffer(keyParameters.keyName),
             data: JSON.stringify(keyParameters.value),
         }
 
@@ -221,7 +222,7 @@ export class APIKeyRequests {
             databaseName,
         )
         if (doesKeyExist.length > 0) {
-            const requestBody = { keyNames: [Buffer.from(keyName, 'utf-8')] }
+            const requestBody = { keyNames: [stringToBuffer(keyName)] }
             const response = await this.apiClient.delete(
                 bufferPathMask.replace('databaseId', databaseId),
                 {

tests/playwright/helpers/utils.ts

@@ -32,3 +32,7 @@ export async function navigateToStandaloneInstance(page: Page): Promise<void> {
     await expect(db).toBeVisible({ timeout: 5000 })
     await db.first().click()
 }
+
+export function stringToBuffer(str: string): Buffer {
+    return Buffer.from(str, 'utf-8')
+}

tests/playwright/pageObjects/browser-page.ts

@@ -1333,21 +1333,23 @@ export class BrowserPage extends BasePage {
 
     async isKeyDetailsClosed(): Promise<boolean> {
         try {
-            // Give a small moment for UI transitions to complete
-            await this.page.waitForTimeout(100)
-
-            // Check if the key details header is gone
-            const headerIsVisible = await this.page
-                .getByTestId('key-details-header')
-                .isVisible()
-
-            // Check if the close right panel button is not visible
-            const closeRightPanelBtn = await this.page
-                .getByTestId('close-right-panel-btn')
-                .isVisible()
+            // Wait for either the header to disappear OR the close button to disappear
+            // This ensures we wait for the UI transition to complete
+            await expect
+                .poll(async () => {
+                    const headerIsVisible = await this.page
+                        .getByTestId('key-details-header')
+                        .isVisible()
+                    const closeRightPanelBtn = await this.page
+                        .getByTestId('close-right-panel-btn')
+                        .isVisible()
+
+                    // Return true if details are closed (header gone OR close button gone)
+                    return !headerIsVisible || !closeRightPanelBtn
+                })
+                .toBe(true)
 
-            // Details are closed if header is gone OR close panel button is not visible
-            return !headerIsVisible || !closeRightPanelBtn
+            return true
         } catch (error) {
             return false
         }
@@ -1383,10 +1385,6 @@ export class BrowserPage extends BasePage {
         }
     }
 
-    async getKeyTTL(): Promise<string | null> {
-        return this.keyDetailsTTL.textContent()
-    }
-
     async getAllListElements(): Promise<string[]> {
         // Get all list elements' text content
         const elements = await this.listElementsList.all()
@@ -1487,7 +1485,7 @@ export class BrowserPage extends BasePage {
     }
 
     async verifyKeyTTL(expectedTTL?: number): Promise<void> {
-        const displayedTTL = await this.getKeyTTL()
+        const displayedTTL = await this.keyDetailsTTL.textContent()
         expect(displayedTTL).toContain('TTL:')
 
         if (expectedTTL !== undefined) {