-
Notifications
You must be signed in to change notification settings - Fork 421
RI-7754 detect system color change #5268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7d01faf
add useSystemThemeListener.ts, it should detect system change
pd-redis 843336c
a little defensive coding to ensure that mediaQuery is indeed defined…
pd-redis bfefbf8
clean up only if mediaQuery exists
pd-redis 324ddfd
refactor: improve system theme listener hook
pd-redis 0c9a64c
refactor: improve system theme listener hook
pd-redis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
redisinsight/ui/src/services/hooks/useSystemThemeListener.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { useEffect } from 'react' | ||
| import { Theme, THEME_MATCH_MEDIA_DARK } from 'uiSrc/constants' | ||
| import { useThemeContext } from 'uiSrc/contexts/themeContext' | ||
|
|
||
| /** | ||
| * Hook that listens to OS system theme changes | ||
| * and updates the theme context when user has System theme selected. | ||
| */ | ||
| export const useSystemThemeListener = () => { | ||
| const { usingSystemTheme, changeTheme } = useThemeContext() | ||
|
|
||
| useEffect(() => { | ||
| const handleSystemThemeChange = () => { | ||
| changeTheme(Theme.System) | ||
| } | ||
| const mediaQuery = window.matchMedia?.(THEME_MATCH_MEDIA_DARK) | ||
| if (usingSystemTheme && mediaQuery) { | ||
| mediaQuery.addEventListener('change', handleSystemThemeChange) | ||
| } | ||
|
|
||
| return () => { | ||
| mediaQuery?.removeEventListener('change', handleSystemThemeChange) | ||
| } | ||
| }, [usingSystemTheme, changeTheme]) | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.