#3681 - Incorrect global variable assignment. Thanks @webbudesign

Signed-off-by: Kev Provance <[email protected]>

Author: kprovance

redux-core/inc/classes/class-redux-api.php

@@ -404,7 +404,7 @@ public static function create_redux() {
 			foreach ( self::$sections as $opt_name => $the_sections ) {
 				if ( ! empty( $the_sections ) ) {
 					if ( ! self::$init[ $opt_name ] ) {
-						self::loadRedux( $opt_name );
+						self::load_redux( $opt_name );
 					}
 				}
 			}
@@ -905,7 +905,6 @@ public static function set_field( string $opt_name = '', $section_id = '', array
 			// Shim for the old method!
 			if ( is_array( $section_id ) ) {
 				$field = $section_id;
-
 				if ( isset( $field['section_id'] ) ) {
 					$section_id = $field['section_id'];
 				}
@@ -1123,7 +1122,7 @@ public static function set_developer( string $opt_name = '', $arg = '' ) {
 		}
 
 		/**
-		 * Deprecated Retrieves option panel global argument array.
+		 * Deprecated Retries option panel global argument array.
 		 *
 		 * @param string $opt_name Panel opt_name.
 		 *
@@ -1135,7 +1134,7 @@ public static function getArgs( string $opt_name = '' ) { // phpcs:ignore WordPr
 		}
 
 		/**
-		 * Retrieves option panel global argument array.
+		 * Retries option panel global argument array.
 		 *
 		 * @param string $opt_name Panel opt_name.
 		 * @param string $key      Argument key name to be returned.
@@ -1224,6 +1223,8 @@ public static function get_post_meta( string $opt_name = '', $the_post = array()
 
 			$redux = ReduxFrameworkInstances::get_instance( $opt_name );
 
+			// We don't ever need to specify advanced_metaboxes here as all function for metaboxes are core,
+			// and thus, metabox_lite.  The extension handles its own functions and is handled by this condition. - kp.
 			$metaboxes = $redux->extensions['metaboxes'];
 
 			if ( null === $default || '' === $default ) {
@@ -1690,8 +1691,7 @@ public static function get_extensions( string $opt_name = '', string $key = '' )
 
 		/**
 		 * Method to disables Redux demo mode popup.
-		 *
-		 * @noinspection PhpUnused*/
+		 */
 		public static function disable_demo() {
 			add_action( 'ReduxFrameworkPlugin_admin_notice', 'Redux::remove_demo' );
 			add_action( 'redux_framework_plugin_admin_notice', 'Redux::remove_demo' );
@@ -1707,7 +1707,7 @@ public static function remove_demo() {
 		/**
 		 * Function which forces a panel/page to render.
 		 *
-		 * @param string/ReduxFramework $redux Panel opt_name or Redux object.
+		 * @param string|object $redux Panel opt_name or Redux object.
 		 */
 		public static function render( $redux = '' ) {
 			if ( is_string( $redux ) ) {
@@ -1716,7 +1716,6 @@ public static function render( $redux = '' ) {
 					return;
 				}
 			}
-
 			$enqueue = new Redux_Enqueue( $redux );
 			$enqueue->init();
 			$panel = new Redux_Panel( $redux );

redux-core/inc/classes/class-redux-args.php

@@ -380,7 +380,7 @@ private function change_demo_defaults( array $args ) {
 		private function default_cleanup( array $args ): array {
 
 			// Fix the global variable name.
-			if ( '' === $args['global_variable'] || false !== $args['global_variable'] ) {
+			if ( '' === $args['global_variable'] && false !== $args['global_variable'] ) {
 				$args['global_variable'] = str_replace( '-', '_', $args['opt_name'] );
 			}
 

redux-core/inc/classes/class-redux-options-constructor.php

@@ -548,7 +548,7 @@ public function register() {
 						// phpcs:ignore WordPress.NamingConventions.ValidHookName
 						$field = apply_filters( "redux/options/{$core->args['opt_name']}/field/{$field['id']}", $field );
 
-						if ( empty( $field ) ) {
+						if ( empty( $field ) || ! $field ) {
 							unset( $core->sections[ $k ]['fields'][ $fieldk ] );
 							continue;
 						}
@@ -675,9 +675,9 @@ public function register() {
 		 *
 		 * @since       1.0.0
 		 * @access      public
-		 * @return      array|null|string $this->options_defaults
+		 * @return      array $this->options_defaults
 		 */
-		public function default_values() {
+		public function default_values(): array {
 			$core = $this->core();
 
 			if ( ! is_null( $core->sections ) && is_null( $core->options_defaults ) ) {