Skip to content

Commit a460453

Browse files
authored
👷 Remove defunct strictOptionalProperties refs (#1219)
1 parent 3925102 commit a460453

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

.github/workflows/tests.yml

-4
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,6 @@ jobs:
110110
if: ${{ matrix.ts < 4.1 }}
111111
run: sed -i -e 's/@pre41-ts-ignore/@ts-ignore/' -e '/pre41-remove-start/,/pre41-remove-end/d' ./src/tests/*.* ./src/query/tests/*.ts*
112112

113-
- name: 'disable strictOptionalProperties'
114-
if: ${{ matrix.ts == 'next' }}
115-
run: sed -i -e 's|//\(.*strictOptionalProperties.*\)$|\1|' tsconfig.base.json
116-
117113
- name: Test types
118114
run: |
119115
./node_modules/.bin/tsc --version

tsconfig.base.json

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
"rootDir": "./src",
1111
// stricter type-checking for stronger correctness. Recommended by TS
1212
"strict": true,
13-
// "strictOptionalProperties": false, // disable strictOptionalProperties for now to also build with 4.4
1413
// linter checks for common issues
1514
"noImplicitReturns": true,
1615
"noFallthroughCasesInSwitch": true,

0 commit comments

Comments
 (0)