Merge pull request #85 from rwillrich/throws-when-select-is-not-an-object

Throws an error when `select` not returns an object

Author: gaearon

src/components/createConnector.js

@@ -1,5 +1,7 @@
 import identity from 'lodash/utility/identity';
 import shallowEqual from '../utils/shallowEqual';
+import isPlainObject from 'lodash/lang/isPlainObject';
+import invariant from 'invariant';
 
 export default function createConnector(React) {
   const { Component, PropTypes } = React;
@@ -59,6 +61,13 @@ export default function createConnector(React) {
     selectState({ context, props } = this) {
       const state = context.redux.getState();
       const slice = props.select(state);
+
+      invariant(
+        isPlainObject(slice),
+        'The return value of `select` prop must be an object. Instead received %s.',
+        slice
+      );
+
       return { slice };
     }
 

test/components/Connector.spec.js

@@ -144,5 +144,21 @@ describe('React', () => {
       const div = TestUtils.findRenderedDOMComponentWithTag(tree, 'div');
       expect(div.props.dispatch).toBe(redux.dispatch);
     });
+
+    it('should throw an error if `state` returns anything but a plain object', () => {
+      const redux = createRedux(() => {});
+
+      expect(() => {
+        TestUtils.renderIntoDocument(
+          <Provider redux={redux}>
+            {() => (
+              <Connector state={() => 1}>
+                {() => <div />}
+              </Connector>
+            )}
+          </Provider>
+        );
+      }).toThrow(/select/);
+    });
   });
 });