Merge pull request #253 from ehossack/fix/bucket-name-restrictions

Fix an issue calling incorrect api

Author: ppolewicz

CHANGELOG.md

@@ -15,6 +15,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Refactored `FileVersionInfo` to `FileVersion`
 * `ScanPoliciesManager` exclusion interface changed
 
+### Fixed
+* Fix call to incorrect internal api in `B2Api.get_download_url_for_file_name`
+
 ## [1.8.0] - 2021-05-21
 
 ### Added

b2sdk/api.py

@@ -434,7 +434,7 @@ def get_download_url_for_file_name(self, bucket_name, file_name):
         :param str bucket_name: a bucket name
         :param str file_name: a file name
         """
-        self.check_bucket_restrictions(bucket_name)
+        self.check_bucket_name_restrictions(bucket_name)
         return '%s/file/%s/%s' % (
             self.account_info.get_download_url(), bucket_name, b2_url_encode(file_name)
         )

test/unit/v_all/test_api.py

@@ -61,3 +61,17 @@ def test_get_bucket_by_id_v2(self):
         self.cache.save_bucket(Bucket(api=self.api, name='bucket_name', id_='bucket_id'))
         read_bucket = self.api.get_bucket_by_id('bucket_id')
         assert read_bucket.name == 'bucket_name'
+
+    def test_get_download_url_for_file_name(self):
+        self._authorize_account()
+
+        download_url = self.api.get_download_url_for_file_name('bucket1', 'some-file.txt')
+
+        assert download_url == 'http://download.example.com/file/bucket1/some-file.txt'
+
+    def test_get_download_url_for_fileid(self):
+        self._authorize_account()
+
+        download_url = self.api.get_download_url_for_fileid('file-id')
+
+        assert download_url == 'http://download.example.com/b2api/v2/b2_download_file_by_id?fileId=file-id'