Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close-out-of-view-modals: doesn't seem to work #8261

Closed
1 task done
nazdridoy opened this issue Feb 5, 2025 · 4 comments
Closed
1 task done

close-out-of-view-modals: doesn't seem to work #8261

nazdridoy opened this issue Feb 5, 2025 · 4 comments
Labels
bug help wanted small Issues that new contributors can pick up

Comments

@nazdridoy
Copy link

Description

doesn't automatically closes dropdown menus when they’re no longer visible.

Image
Image
Image

How to replicate the issue + URL

refined-github/sandbox#3

Extension version

25.1.24

Browser(s) used

firefox, zen

Token ⚠️

  • I set a token in the options page. I understand that some features require a token to work.
@nazdridoy nazdridoy added the bug label Feb 5, 2025
@fregante
Copy link
Member

fregante commented Feb 6, 2025

Are they modals or are they just dropdowns?

See #7393

The reason for the feature to exist is that you would scroll down, see nothing, but the first click on the page would just be swallowed because the modal was open. It doesn't seem to be the case with these new dropdowns.

@fregante fregante added help wanted small Issues that new contributors can pick up labels Feb 6, 2025
@nazdridoy
Copy link
Author

tbh, i don't understand what you are asking, all i can say that currtly the feature is not working as shown here

image

@fregante
Copy link
Member

fregante commented Feb 6, 2025

This is a modal:

Image

This isn't:

Image

@fregante
Copy link
Member

fregante commented Feb 6, 2025

You can see that with the modal, the first click outside the modal is lost.

With non-modals, this does not happen; you click, it works.

Given the name, the feature does not apply to non-modals.

Since GitHub appears to have finally fixed how they show most or all dropdowns, I expect to drop close-out-of-view-modals sometime in the future.

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted small Issues that new contributors can pick up
Development

No branches or pull requests

2 participants