Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocrafting task end notification wait for any GUI to be closed to popup #804

Closed
jonatjano opened this issue Feb 3, 2025 · 5 comments
Closed
Labels
bug Something isn't working can't reproduce We are unable to reproduce this issue

Comments

@jonatjano
Copy link

Describe the issue

Autocrafting tasks with notification on will wait for the player to close any GUI before poping up

How can we reproduce this bug or crash?

  1. launch an autocrafting task with notification on
  2. open a GUI
  3. wait more time than needed for the task to end
  4. repeat from step 1. if wanted
  5. close the GUI
  6. see all the notification pop at the same time

What Minecraft version is this happening on?

Minecraft 1.21.1

What NeoForge or Fabric version is this happening on?

21.1.115

What Refined Storage version is this happening on?

2.0.0 milestone 4.13

@raoulvdberge raoulvdberge moved this to Todo in Refined Storage Feb 5, 2025
@raoulvdberge raoulvdberge added this to the v2.0.0-milestone.4 milestone Feb 5, 2025
@raoulvdberge raoulvdberge added the bug Something isn't working label Feb 5, 2025
@raoulvdberge raoulvdberge moved this from Todo to In Progress in Refined Storage Feb 17, 2025
@raoulvdberge
Copy link
Contributor

@jonatjano I cannot seem to reproduce this:

Image

@raoulvdberge raoulvdberge added the can't reproduce We are unable to reproduce this issue label Feb 17, 2025
@raoulvdberge
Copy link
Contributor

Let me know. I'll close for now.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Refined Storage Feb 18, 2025
@jonatjano
Copy link
Author

jonatjano commented Feb 19, 2025

After more tests, It is an EMI issue, vanilla achievement notifications don't show either when a gui is open with EMI. I'll report on their side

@jonatjano
Copy link
Author

a little follow up on this for the record, this is intended behavior on EMI's part to avoid overlaping the EMI's UI with recipe unlock popups
emilyploszaj/emi#869

@raoulvdberge
Copy link
Contributor

thanks for the follow up

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working can't reproduce We are unable to reproduce this issue
Projects
Status: Done
Development

No branches or pull requests

2 participants