Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit integration? #109

Open
reinout opened this issue Mar 24, 2023 · 3 comments
Open

Pre-commit integration? #109

reinout opened this issue Mar 24, 2023 · 3 comments

Comments

@reinout
Copy link
Owner

reinout commented Mar 24, 2023

I'm using pre-commit in more and more projects. I was thinking... wouldn't a pre-commit integration hook be a nice addition to dependencychecker?

@gforcada
Copy link
Collaborator

We have thought on that during the Alpine City Sprint 2023, and what we thought is that, it might be not something you want to run on a per-commit basis, rather as a PR or scheduled CI? 🤔

Specially, given that there are some rough edges to be ironed out, for non-experienced developers it might confuse them even more.

But that was mostly with my Plone contributor hat on, generally speaking, indeed, having it as an option for anyone who wants to use it, it would be great 👍🏾

@gforcada
Copy link
Collaborator

Actually, as @mauritsvanrees mentioned in plone/meta#84 z3c.dependencychecker does not really need the actual dependencies to analyze the package, it needs an updated egg-info folder only.

I created a PR in plone/meta with this idea, see plone/meta#86 and it is really fast to run on my slow laptop, so I think it might not be a bad idea to add it as a pre-commit hook 👍🏾

On that PR in plone/meta I used build to generate the .egg-info folder.

We need to see how we can combine build and z3c.dependencychecker for pre-commit but I would say, let's try 😄

@mauritsvanrees
Copy link
Collaborator

build is something we should look at for zest.releaser as well, instead of calling python setup.py sdist/bdist_wheel/--version/etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants