Issues with retry and logging upon exception during consumption

[blaines]

I had a misconfiguration with my Hermann consumer which caused an exception to occur:

Hermann::Provider::JavaSimpleConsumer#consume EXCEPTION java.lang.IllegalArgumentException: Invalid path string "/brokers/topics//auditlog_events" caused by empty node name specified @16

Locating the source of this issue was much more difficult than expected because the exception was caught here [1], and retry did not seem to occur at all [2]. I've done some basic debugging to verify that the execution path does in fact call retry but I haven't been able to actually get a retry to occur. retry?:true @max_retries:3 @backoff_time_sec:1

I think there's a few issues with this code:

1. An exception occurs, and could potentially not be reported because of [3] return unless @logger
2. retry doesn't appear to be working as expected
3. rescue might be overzealous, I'm not sure it makes sense to retry any exception
4. A bonus, it might be beneficial to validate this value prior to execution

For now, I've fixed the cause of the exception in my code, but don't have any specific suggestions yet on how to resolve the listed issues above.

[1] https://github.com/lookout/Hermann/blob/master/lib/hermann/provider/java_simple_consumer.rb#L79
[2] https://github.com/lookout/Hermann/blob/master/lib/hermann/provider/java_simple_consumer.rb#L83
[3] https://github.com/lookout/Hermann/blob/master/lib/hermann/provider/java_simple_consumer.rb#L97