Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node 23 #1173

Open
ehmicky opened this issue Oct 27, 2024 · 4 comments
Open

Add support for Node 23 #1173

ehmicky opened this issue Oct 27, 2024 · 4 comments

Comments

@ehmicky
Copy link

ehmicky commented Oct 27, 2024

If --engine-strict is used, npm install fails with:

npm error code EBADENGINE
npm error engine Unsupported engine
npm error engine Not compatible with your version of node/npm: [email protected]
npm error notsup Not compatible with your version of node/npm: [email protected]
npm error notsup Required: {"node":"^18.18.0 || ^20.9.0 || ^22.0.0"}
npm error notsup Actual:   {"npm":"10.9.0","node":"v23.1.0"}

If --engine-strict is not used, a warning is printed instead, but npm install does not fail.

@webpro
Copy link
Collaborator

webpro commented Oct 31, 2024

We haven't tested it on Node.js v23 yet, feel free to do so.

@bmish
Copy link
Contributor

bmish commented Dec 5, 2024

For the record, it looks like this change from supporting all future Node versions to only the specified Node versions occurred here: 24b3ba6

What do you think is the best practice here?

Personally, I find it more convenient to include all future Node versions in the engines range, like eslint does for example:

https://github.com/eslint/eslint/blob/ee8c2200a19dd55aa5068b6cd336a2aec7c52ad3/package.json#L217

That makes it easier for consumers to install / run / test the package under all the latest / supported Node versions, without depending on every package to release an update to expand the range every six months.

@webpro
Copy link
Collaborator

webpro commented Dec 7, 2024

Agreed, Node.js is stable enough. Feel free to open a PR for this.

@philippdormann
Copy link

Personally, I find it more convenient to include all future Node versions in the engines range, like eslint does for example:

https://github.com/eslint/eslint/blob/ee8c2200a19dd55aa5068b6cd336a2aec7c52ad3/package.json#L217

That makes it easier for consumers to install / run / test the package under all the latest / supported Node versions, without depending on every package to release an update to expand the range every six months.

just opened a PR with this exact implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants