-
-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Node 23 #1173
Comments
We haven't tested it on Node.js v23 yet, feel free to do so. |
For the record, it looks like this change from supporting all future Node versions to only the specified Node versions occurred here: 24b3ba6 What do you think is the best practice here? Personally, I find it more convenient to include all future Node versions in the engines range, like eslint does for example: https://github.com/eslint/eslint/blob/ee8c2200a19dd55aa5068b6cd336a2aec7c52ad3/package.json#L217 That makes it easier for consumers to install / run / test the package under all the latest / supported Node versions, without depending on every package to release an update to expand the range every six months. |
Agreed, Node.js is stable enough. Feel free to open a PR for this. |
just opened a PR with this exact implementation |
If
--engine-strict
is used,npm install
fails with:If
--engine-strict
is not used, a warning is printed instead, but npm install does not fail.The text was updated successfully, but these errors were encountered: