Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Arrow key navigation appears to be broken #15

Open
mbrgm opened this issue Nov 22, 2024 · 1 comment
Open

Bug: Arrow key navigation appears to be broken #15

mbrgm opened this issue Nov 22, 2024 · 1 comment

Comments

@mbrgm
Copy link

mbrgm commented Nov 22, 2024

Step to reproduce

  1. Open baRSS menu.
  2. Place cursor above first entry ("Pause Updates").
  3. Change highlighted entry by repeatedly pressing down arrow key.

Expected behavior

  • Highlighted item is changed one by one in a subsequent manner for each key press.

Actual behavior

  • After reaching "Open all unread", highlight moves back up to the menubar item, then continues with the first menu item ("Pause Updates").
  • The same behavior can be observed when moving up from the bottom. In this case, the wrapping happens after "Mark all read".
@relikd
Copy link
Owner

relikd commented Nov 22, 2024

I'll be travelling the next few month, therefore I can not look at the problem at the moment. But I will get back to you as soon as I can.

First guess:

NSMenuItem *itm = [self addItemIfAllowed:TagOpenAllUnread title:NSLocalizedString(@"Open all unread", nil)];
if (itm) {
NSString *altTitle = [NSString stringWithFormat:NSLocalizedString(@"Open a few unread (%lu)", nil), UserPrefsUInt(Pref_openFewLinksLimit)];
[self addItem:[itm alternateWithTitle:altTitle]];
}

this creates a hidden menu entry which is only shown when holding down alt/option. I assume this breaks the "highlight next item" logic. I wonder whether other apps have this problem with alternative-items or not. I assume the other work as expected, thus I have to try to create the menu item differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants