Skip to content

Commit 46305d4

Browse files
committed
Allow NewDynamoDBClient to accept a client.ConfigProvider.
1 parent 8339ebe commit 46305d4

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

dynamodb_client/base_table_client_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import (
66
"testing"
77

88
"github.com/aws/aws-sdk-go/aws"
9+
"github.com/aws/aws-sdk-go/aws/session"
910
"github.com/aws/aws-sdk-go/service/dynamodb"
1011
"github.com/aws/aws-sdk-go/service/dynamodb/dynamodbattribute"
1112
. "github.com/remind101/pkg/dynamodb_client"
@@ -57,7 +58,7 @@ func newFreshDynamoClient() *DynamoClient {
5758
Scope: "client-test",
5859
TableDescriptions: AllTableDescriptions,
5960
}
60-
c := NewDynamoDBClient(params)
61+
c := NewDynamoDBClient(session.New(), params)
6162
c.DeleteTables()
6263
c.CreateTables()
6364
return c

dynamodb_client/dynamo.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import (
66

77
"github.com/aws/aws-sdk-go/aws"
88
"github.com/aws/aws-sdk-go/aws/awserr"
9-
"github.com/aws/aws-sdk-go/aws/session"
9+
"github.com/aws/aws-sdk-go/aws/client"
1010
"github.com/aws/aws-sdk-go/service/dynamodb"
1111
"github.com/aws/aws-sdk-go/service/dynamodb/dynamodbiface"
1212
"github.com/remind101/pkg/logger"
@@ -26,15 +26,15 @@ type DynamoConnectionParams struct {
2626
ServiceName string // Name to use in apm
2727
}
2828

29-
func NewDynamoDBClient(params DynamoConnectionParams) *DynamoClient {
29+
func NewDynamoDBClient(c client.ConfigProvider, params DynamoConnectionParams) *DynamoClient {
3030
if params.RegionName == "" {
3131
params.RegionName = "us-east-1"
3232
}
3333
config := aws.Config{
3434
Region: aws.String(params.RegionName),
3535
Endpoint: aws.String(params.LocalDynamoURL),
3636
}
37-
svc := dynamodb.New(session.New(), &config)
37+
svc := dynamodb.New(c, &config)
3838
//svc.Handlers.Retry.PushFrontNamed(CheckThrottleHandler)
3939

4040
return &DynamoClient{

0 commit comments

Comments
 (0)